Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Address comments from PS11-13 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
index 1eef544c32764859079ef18e1e4c487bda4ae1d2..2cb2df72f8efa99ad178c3d3617f2c00fa60a295 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"
#endif // OS_ANDROID
#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"
+#include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h"
@@ -93,6 +94,10 @@ void PageLoadMetricsEmbedder::RegisterObservers(
tracker->AddObserver(base::MakeUnique<CssScanningMetricsObserver>());
tracker->AddObserver(base::MakeUnique<ProtocolPageLoadMetricsObserver>());
tracker->AddObserver(base::MakeUnique<TabRestorePageLoadMetricsObserver>());
+ std::unique_ptr<AdsPageLoadMetricsObserver> ads_observer =
+ AdsPageLoadMetricsObserver::CreateIfNeeded();
+ if (ads_observer)
+ tracker->AddObserver(std::move(ads_observer));
std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> ukm_observer =
UkmPageLoadMetricsObserver::CreateIfNeeded(web_contents_);

Powered by Google App Engine
This is Rietveld 408576698