Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5269)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Remove dcheck Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.cc
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.cc b/chrome/browser/page_load_metrics/page_load_tracker.cc
index 10e75f5f333bc65ed07c4c56204a637b16e7f032..816bcf6fde3a3e8c139785484132b5174cc1174e 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.cc
+++ b/chrome/browser/page_load_metrics/page_load_tracker.cc
@@ -439,8 +439,10 @@ void PageLoadTracker::WillProcessNavigationResponse(
// PlzNavigate: NavigationHandle::GetGlobalRequestID() sometimes returns an
// uninitialized GlobalRequestID. Bail early in this case. See
// crbug.com/680841 for details.
- if (content::IsBrowserSideNavigationEnabled() &&
- navigation_handle->GetGlobalRequestID() == content::GlobalRequestID())
+ // TODO(jkarlin): NavigationSimulator is the first unittest framework to hit
+ // this function, and it doesn't provide a GlobalRequestID. Add an ID. See
+ // crbug.com/711352 for details.
+ if (navigation_handle->GetGlobalRequestID() == content::GlobalRequestID())
return;
DCHECK(!navigation_request_id_.has_value());
@@ -463,6 +465,11 @@ void PageLoadTracker::Commit(content::NavigationHandle* navigation_handle) {
LogAbortChainHistograms(navigation_handle);
}
+void PageLoadTracker::DidCommitSubFrame(
+ content::NavigationHandle* navigation_handle) {
+ INVOKE_AND_PRUNE_OBSERVERS(observers_, OnCommitSubFrame, navigation_handle);
+}
+
void PageLoadTracker::FailedProvisionalLoad(
content::NavigationHandle* navigation_handle,
base::TimeTicks failed_load_time) {

Powered by Google App Engine
This is Rietveld 408576698