Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6906)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Remove dcheck Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index f3fa5d03ba0a44dffa7c175406b0bab005279369..eb132e44666b0bbc9f3207571acfd99baa8eeb8c 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -54,11 +54,15 @@ PageLoadExtraInfo PageLoadExtraInfo::CreateForTesting(
page_load_metrics::PageLoadMetadata());
}
-ExtraRequestInfo::ExtraRequestInfo(bool was_cached,
+ExtraRequestInfo::ExtraRequestInfo(const GURL& url,
+ int frame_tree_node_id,
+ bool was_cached,
int64_t raw_body_bytes,
bool data_reduction_proxy_used,
int64_t original_network_content_length)
- : was_cached(was_cached),
+ : url(url),
+ frame_tree_node_id(frame_tree_node_id),
+ was_cached(was_cached),
raw_body_bytes(raw_body_bytes),
data_reduction_proxy_used(data_reduction_proxy_used),
original_network_content_length(original_network_content_length) {}
@@ -90,6 +94,12 @@ PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnCommit(
return CONTINUE_OBSERVING;
}
+PageLoadMetricsObserver::ObservePolicy
+PageLoadMetricsObserver::OnCommitSubFrame(
+ content::NavigationHandle* navigation_handle) {
+ return CONTINUE_OBSERVING;
+}
+
PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden(
const PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {

Powered by Google App Engine
This is Rietveld 408576698