chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc - Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)

Patch Set: Add tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('k') | chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

index 1ca46382299e83c93f88b8e6d3381597e85aa6f9..a145963b187a3184e7bc247ebd8e359d28e36600 100644

--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

@@ -110,10 +110,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, Basic) {

TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {

NavigateAndCommit(GURL(kDefaultTestUrl));

- SimulateLoadedResource({false /* was_cached */,

- 1024 * 40 /* raw_body_bytes */,

- false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ SimulateLoadedResource(

+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,

+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used */,

+ 0 /* original_network_content_length */});

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

@@ -122,12 +122,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {

blink::WebLoadingBehaviorFlag::WebLoadingBehaviorSubresourceFilterMatch;

SimulateTimingAndMetadataUpdate(timing, metadata);

- SimulateLoadedResource({false /* was_cached */,

- 1024 * 20 /* raw_body_bytes */,

- false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ SimulateLoadedResource(

+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,

+ 1024 * 20 /* raw_body_bytes */, false /* data_reduction_proxy_used */,

+ 0 /* original_network_content_length */});

- SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,

+ SimulateLoadedResource({GURL(), -1 /* frame_tree_node_id */,

+ true /* was_cached */, 1024 * 10 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

0 /* original_network_content_length */});