Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Address comments from PS20 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/public/browser/resource_request_info.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 3693d2ee9ed282d95217f401b2e437f21882fa46..0c7361f0930070e89cd2a026f09c234a31c5474e 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -46700,6 +46700,250 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="PageLoad.Clients.Ads.Google.AdFrameCount" units="Ad frames">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The number of frames on the page identified as Google Ad Frames.
+
+ For pages with zero ad frames, the other PageLoad.Clients.Ads metrics are
+ not recorded.
Ilya Sherman 2017/04/27 00:25:28 nit: unless otherwise specified
jkarlin 2017/04/28 15:11:20 Done.
+
+ Child frames of an ad frame are not included in the count.
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.AdFrameCount.MainFrame"
+ units="Frames">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The number of frames (with parent frame of main frame) that are on the page
+ identified as Google Ad Frames.
+
+ Only recorded if the page has at least one identified ad frame. Child frames
+ of an ad frame are not included in the count.
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.AdFrameRenavigatedToAd"
+ units="DidNavigateToAd">
Ilya Sherman 2017/04/27 00:25:28 nit: s/units/enum
jkarlin 2017/04/28 15:11:20 Done.
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ When a frame that is (or previously was) an ad frame renavigates, record
+ whether it renavigated to an ad frame or a non-ad frame.
+
+ An ad frame consists of the identified ad frame and all of its children. Its
+ children (which may also be ads) are not counted when they renavigate.
+
+ This metric is recorded as the event happens, not when the page is complete
+ like the rest of the Clients.Ads metrics (unless otherwise specified).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.AllAdFrames.Network"
+ units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of the resources loaded for all of the ad frames on the
+ page that loaded over the network.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
Ilya Sherman 2017/04/27 00:25:28 nit: s/does/do
jkarlin 2017/04/28 15:11:20 Done. Here and elsewhere.
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.AllAdFrames.Total"
+ units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of the resources loaded for all of the ad frames on the
+ page.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.Network" units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of all of the page's resources that loaded over the
+ network.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.NonAdFrames.Total"
+ units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of all of the page's resources except for those loaded in
+ ad frames.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PerAdFrame.Network"
+ units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of the resources loaded for an ad frame from the network.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PerAdFrame.Total" units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of the resources loaded for an ad frame.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PercentAdFrame.Network"
+ units="%">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The percentage of bytes loaded for a single ad frame that were loaded over
+ the network.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PercentAllAdFrames.Network"
+ units="%">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The percentage of bytes loaded for all ad frames that were loaded over the
+ network.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram
+ name="PageLoad.Clients.Ads.Google.Bytes.PercentPage.AllAdFrames.Network"
+ units="%">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The percentage of bytes loaded for the page (from the network) that came
+ from resource loads in ad frames (from the network).
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram
+ name="PageLoad.Clients.Ads.Google.Bytes.PercentPage.AllAdFrames.Total"
+ units="%">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The percentage of bytes loaded for the page that came from resource loads in
+ ad frames.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame). The percentage of the page's prefiltered (e.g.,
+ compressed) response body KB loaded from frames (and their child frames)
+ identified as Google Ad Frames.
Ilya Sherman 2017/04/27 00:25:28 I don't understand the last sentence in this parag
jkarlin 2017/04/28 15:11:20 Wasn't supposed to be there. Removed.
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.Total" units="KB">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The size (in KB) of all of the page's resources.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
Ilya Sherman 2017/04/27 00:25:29 This histogram does not measure ad frames, right?
jkarlin 2017/04/28 15:11:20 Done.
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.NonAdFrameRenavigatedToAd"
+ units="DidNavigateToAd">
Ilya Sherman 2017/04/27 00:25:28 nit: s/units/enum
jkarlin 2017/04/28 15:11:20 Done.
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ When a frame that has never been part of an ad frame renavigates, record
+ whether it renavigated to an ad frame or a non-ad frame.
+
+ This metric is recorded as the event happens, not when the page is complete
+ like the rest of the Clients.Ads metrics (unless otherwise specified).
Ilya Sherman 2017/04/27 00:25:28 I find this sentence somewhat confusing. I'd reph
jkarlin 2017/04/28 15:11:20 Done.
+ </summary>
+</histogram>
+
+<histogram
+ name="PageLoad.Clients.Ads.Google.PercentSubFramesAreAdFrames.MainFrame"
+ units="%">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The percentage of frames (with parent frame of main frame) on the page that
+ are identified as Google Ad Frames.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.SubFrameCount.MainFrame"
+ units="Frames">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ The number of frames frames (with parent frame of main frame) on the page.
Ilya Sherman 2017/04/27 00:25:29 nit: s/frames frames/frames
jkarlin 2017/04/28 15:11:20 Done.
+
+ Only recorded if the page has at least one identified ad frame. Bytes are
+ measured as over-the-wire (e.g., compressed) response body KBs and does not
+ include header bytes. An ad frame consists of the identified ad frame and
Ilya Sherman 2017/04/27 00:25:28 This histogram does not measure bytes, nor does it
jkarlin 2017/04/28 15:11:20 Done.
+ all of its children (which may also be ads, but are counted as part of the
+ ancestor ad frame).
+ </summary>
+</histogram>
+
<histogram
name="PageLoad.Clients.DataReductionProxy.Experimental.Bytes.Network.CompressionRatio"
units="%">
@@ -89678,6 +89922,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="18" label="IME Warning (Activation)"/>
</enum>
+<enum name="DidNavigateToAd" type="int">
+ <int value="0" label="Navigated to Non-Ad"/>
+ <int value="1" label="Navigated to Ad"/>
+</enum>
+
<enum name="DifferentPrimaryAccounts" type="int">
<int value="0" label="Primary Accounts the same"/>
<int value="1" label="(obsolete) Primary Accounts different"/>
« no previous file with comments | « content/public/browser/resource_request_info.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698