tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 72a733f9ef2639e6d54442cc13a124880be7ca6f..abf1ac960a5ede0640f87832edc751e550a4ec99 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -45923,6 +45923,152 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="PageLoad.Clients.Ads.Google.AdFrameCount" units="AdFrames">

[Charlie Harrison, 2017/04/14 20:16:26]

If we're planning in the future to have non suffixed "Google" histograms, should
we try to structure these as histogram suffixes?

[jkarlin, 2017/04/24 17:27:59]

I'd like to avoid adding the suffixes to the histograms.xml code until it's
needed.

When we decide to make these suffixes the idea is to change the names in
histograms.xml to remove the 'Clients.Ads.Google' bits and then make a
histogram_suffixes with ordering="prefix" and suffix name =
"Clients.Ads.Google", "Clients.Ads", and any other suffixes we need.

The histograms would then be 'Pageload.AdFrameCount, etc..' in histograms.xml.
That uses up some top-level Pageload namespace, which isn't ideal, but I'm not
aware of a better option. I wish we had more control over where the suffix goes
in the histogram because then I could make the suffix name = "Google" and tell
it to go after the "Pageload.Clients.Ads" part.

+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of frames on the page identified as Google Ad Frames (does not
+    include children of ad frames).
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.AdFrameBytes" units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded for a
+    frame (and its child frames) identified as a Google Ad Frame. Child frames
+    of ad frames are not separately reported.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.AdFrameBytesFromNetwork"
+    units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded from
+    the network for a frame (and its child frames) identified as a Google Ad
+    Frame. Child frames of ad frames are not separately reported.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.AllAdFramesBytes" units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded for all
+    ad frames (and their child frames) identified as Google Ad Frames on a page.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.AllAdFramesBytesFromNetwork"
+    units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded from
+    the network for all frames (and their child frames) on a page identified as
+    Google Ad Frames.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PageBytes" units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded for all
+    frames of a page.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PageBytesFromNetwork"
+    units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded from
+    the network for all frames of a page.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.Bytes.PageBytesSansAllAdFrames"
+    units="KB">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of prefiltered (e.g., compressed) response body KB loaded for all
+    frames not identified as Google Ad Frames or their descendants.
+  </summary>
+</histogram>
+
+<histogram
+    name="PageLoad.Clients.Ads.Google.Bytes.PercentAdFrameBytesFromNetwork"
+    units="%">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The percentage of prefiltered (e.g., compressed) response body KB loaded
+    from the network for a frame (and its child frames) identified as a Google
+    Ad Frame. Child frames of ad frames are not separately reported.
+  </summary>
+</histogram>
+
+<histogram
+    name="PageLoad.Clients.Ads.Google.Bytes.PercentAllAdFramesBytesFromNetwork"
+    units="%">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The percentage of prefiltered (e.g., compressed) response body KB loaded
+    from the network from frames (and their child frames) identified as Google
+    Ad Frames out of all prefiltered response body KB loaded for frames
+    identified as ads.
+  </summary>
+</histogram>
+
+<histogram
+    name="PageLoad.Clients.Ads.Google.Bytes.PercentPageBytesFromAllAdFrames"
+    units="%">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The percentage of the page's prefiltered (e.g., compressed) response body KB
+    loaded from frames (and their child frames) identified as Google Ad Frames.
+  </summary>
+</histogram>
+
+<histogram
+    name="PageLoad.Clients.Ads.Google.Bytes.PercentPageNetworkBytesFromAllAdFrames"
+    units="%">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The percentage of the page's prefiltered (e.g., compressed) response body KB
+    loaded from the network from frames (and their child frames) identified as
+    Google Ad Frames.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.PageHasNoAds" units="pages">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of pages loaded that had no frames identified as Google ads.
+  </summary>
+</histogram>
+
+<histogram
+    name="PageLoad.Clients.Ads.Google.PercentTopLevelSubFramesAreAdFrames"
+    units="%">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The percentage of top-level frames on the page that are identified as Google
+    Ad Frames.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.TopLevelAdFrameCount"
+    units="Frames">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>
+    The number of top-level frames on the page identified as Google Ad Frames.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Clients.Ads.Google.TopLevelSubFrameCount"
+    units="Frames">
+  <owner>jkarlin@chromium.org</owner>
+  <summary>The number of top-level frames on the page.</summary>
+</histogram>
+
 <histogram
     name="PageLoad.Clients.DataReductionProxy.Experimental.Bytes.Network.CompressionRatio"
     units="%">