[PageLoadMetrics] Keep track of Ad Sizes on Pages

content/public/browser/resource_request_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
 #define CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
 
 #include "base/callback_forward.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/global_request_id.h"
@@ skipping 55 matching lines @@
       const net::URLRequest* request);
 
   // A callback that returns a pointer to a WebContents. The callback can
   // always be used, but it may return nullptr: if the info used to
   // instantiate the callback can no longer be used to return a WebContents,
   // nullptr will be returned instead.
   // The callback should only run on the UI thread and it should always be
   // non-null.
   using WebContentsGetter = base::Callback<WebContents*(void)>;
 
+  // A callback that returns a frame tree node id . The callback can always
+  // be used, but it may return -1 if no id is found. The callback should only
+  // run on the UI thread.
+  using FrameTreeNodeIdGetter = base::Callback<int(void)>;
+
   // Returns a callback that returns a pointer to the WebContents this request
   // is associated with, or nullptr if it no longer exists or the request is
   // not associated with a WebContents. The callback should only run on the UI
   // thread.
   // Note: Not all resource requests will be owned by a WebContents. For
   // example, requests made by a ServiceWorker.
   virtual WebContentsGetter GetWebContentsGetterForRequest() const = 0;
 
+  // Returns a callback that returns an int with the frame tree node id
+  //   associated with this request, or -1 if it no longer exists. This
+  //   callback should only be run on the UI thread.
+  // Note: Not all resource requests will be associated with a frame. For
+  // example, requests made by a ServiceWorker.
+  virtual FrameTreeNodeIdGetter GetFrameTreeNodeIdGetterForRequest() const = 0;
+
   // Returns the associated ResourceContext.
   virtual ResourceContext* GetContext() const = 0;
 
   // The child process unique ID of the requestor.
   // To get a WebContents, use GetWebContentsGetterForRequest instead.
   virtual int GetChildID() const = 0;
 
   // The IPC route identifier for this request (this identifies the RenderView
   // or like-thing in the renderer that the request gets routed to).
   // To get a WebContents, use GetWebContentsGetterForRequest instead.
   // Don't use this method for new code, as RenderViews are going away.
   virtual int GetRouteID() const = 0;
 
   // The globally unique identifier for this request.
   virtual GlobalRequestID GetGlobalRequestID() const = 0;
 
   // The pid of the originating process, if the request is sent on behalf of a
   // another process.  Otherwise it is 0.
   virtual int GetOriginPID() const = 0;
 
   // Returns the FrameTreeNode ID for this frame. This ID is browser-global and
   // uniquely identifies a frame that hosts content.
+  // Note: Returns -1 for all requests except PlzNavigate requests.
+  // TODO(jkarlin): Set the id for all requests from frames.

[jam, 2017/04/17 15:41:55]

nit: remove this TODO. you can file a bug to discuss this if you want.

IMO it would be confusing to both store the frame tree node ID and RFH IDs for a
non-plznavigate request (i.e. what if they're not consistent?). while ideally we
could just use the frame tree node ID, there's a lot of code that depends on the
RFH IDs for maps and for checking the process part only, so it would be a big
task to convert everything to FTN IDs.

[jkarlin, 2017/04/24 17:27:59]

Done.

   virtual int GetFrameTreeNodeId() const = 0;
 
   // The IPC route identifier of the RenderFrame.
   // To get a WebContents, use GetWebContentsGetterForRequest instead.
   // TODO(jam): once all navigation and resource requests are sent between
   // frames and RenderView/RenderViewHost aren't involved we can remove this and
   // just use GetRouteID above.
   virtual int GetRenderFrameID() const = 0;
 
   // True if GetRenderFrameID() represents a main frame in the RenderView.
@@ skipping 51 matching lines @@
   // UI thread at the beginning of navigation.
   virtual NavigationUIData* GetNavigationUIData() const = 0;
 
  protected:
   virtual ~ResourceRequestInfo() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_