Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Address comments from PS11-13 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadExtraInfo::PageLoadExtraInfo( 9 PageLoadExtraInfo::PageLoadExtraInfo(
10 base::TimeTicks navigation_start, 10 base::TimeTicks navigation_start,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 base::Optional<base::TimeDelta>() /* first_background_time */, 47 base::Optional<base::TimeDelta>() /* first_background_time */,
48 base::Optional<base::TimeDelta>() /* first_foreground_time */, 48 base::Optional<base::TimeDelta>() /* first_foreground_time */,
49 started_in_foreground /* started_in_foreground */, 49 started_in_foreground /* started_in_foreground */,
50 UserInitiatedInfo::BrowserInitiated(), url, url, true /* did_commit */, 50 UserInitiatedInfo::BrowserInitiated(), url, url, true /* did_commit */,
51 page_load_metrics::END_NONE, 51 page_load_metrics::END_NONE,
52 page_load_metrics::UserInitiatedInfo::NotUserInitiated(), 52 page_load_metrics::UserInitiatedInfo::NotUserInitiated(),
53 base::TimeDelta(), page_load_metrics::PageLoadMetadata(), 53 base::TimeDelta(), page_load_metrics::PageLoadMetadata(),
54 page_load_metrics::PageLoadMetadata()); 54 page_load_metrics::PageLoadMetadata());
55 } 55 }
56 56
57 ExtraRequestInfo::ExtraRequestInfo(bool was_cached, 57 ExtraRequestInfo::ExtraRequestInfo(const GURL& url,
58 int frame_tree_node_id,
59 bool was_cached,
58 int64_t raw_body_bytes, 60 int64_t raw_body_bytes,
59 bool data_reduction_proxy_used, 61 bool data_reduction_proxy_used,
60 int64_t original_network_content_length) 62 int64_t original_network_content_length)
61 : was_cached(was_cached), 63 : url(url),
64 frame_tree_node_id(frame_tree_node_id),
65 was_cached(was_cached),
62 raw_body_bytes(raw_body_bytes), 66 raw_body_bytes(raw_body_bytes),
63 data_reduction_proxy_used(data_reduction_proxy_used), 67 data_reduction_proxy_used(data_reduction_proxy_used),
64 original_network_content_length(original_network_content_length) {} 68 original_network_content_length(original_network_content_length) {}
65 69
66 ExtraRequestInfo::ExtraRequestInfo(const ExtraRequestInfo& other) = default; 70 ExtraRequestInfo::ExtraRequestInfo(const ExtraRequestInfo& other) = default;
71 ExtraRequestInfo& ExtraRequestInfo::operator=(const ExtraRequestInfo& other) =
72 default;
67 73
68 ExtraRequestInfo::~ExtraRequestInfo() {} 74 ExtraRequestInfo::~ExtraRequestInfo() {}
69 75
70 FailedProvisionalLoadInfo::FailedProvisionalLoadInfo(base::TimeDelta interval, 76 FailedProvisionalLoadInfo::FailedProvisionalLoadInfo(base::TimeDelta interval,
71 net::Error error) 77 net::Error error)
72 : time_to_failed_provisional_load(interval), error(error) {} 78 : time_to_failed_provisional_load(interval), error(error) {}
73 79
74 FailedProvisionalLoadInfo::~FailedProvisionalLoadInfo() {} 80 FailedProvisionalLoadInfo::~FailedProvisionalLoadInfo() {}
75 81
76 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnStart( 82 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnStart(
77 content::NavigationHandle* navigation_handle, 83 content::NavigationHandle* navigation_handle,
78 const GURL& currently_committed_url, 84 const GURL& currently_committed_url,
79 bool started_in_foreground) { 85 bool started_in_foreground) {
80 return CONTINUE_OBSERVING; 86 return CONTINUE_OBSERVING;
81 } 87 }
82 88
83 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnRedirect( 89 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnRedirect(
84 content::NavigationHandle* navigation_handle) { 90 content::NavigationHandle* navigation_handle) {
85 return CONTINUE_OBSERVING; 91 return CONTINUE_OBSERVING;
86 } 92 }
87 93
88 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnCommit( 94 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnCommit(
89 content::NavigationHandle* navigation_handle) { 95 content::NavigationHandle* navigation_handle) {
90 return CONTINUE_OBSERVING; 96 return CONTINUE_OBSERVING;
91 } 97 }
92 98
99 PageLoadMetricsObserver::ObservePolicy
100 PageLoadMetricsObserver::OnCommitSubFrame(
101 content::NavigationHandle* navigation_handle) {
102 return CONTINUE_OBSERVING;
103 }
104
93 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden( 105 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden(
94 const PageLoadTiming& timing, 106 const PageLoadTiming& timing,
95 const PageLoadExtraInfo& extra_info) { 107 const PageLoadExtraInfo& extra_info) {
96 return CONTINUE_OBSERVING; 108 return CONTINUE_OBSERVING;
97 } 109 }
98 110
99 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnShown() { 111 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnShown() {
100 return CONTINUE_OBSERVING; 112 return CONTINUE_OBSERVING;
101 } 113 }
102 114
103 PageLoadMetricsObserver::ObservePolicy 115 PageLoadMetricsObserver::ObservePolicy
104 PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground( 116 PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(
105 const PageLoadTiming& timing, 117 const PageLoadTiming& timing,
106 const PageLoadExtraInfo& extra_info) { 118 const PageLoadExtraInfo& extra_info) {
107 return CONTINUE_OBSERVING; 119 return CONTINUE_OBSERVING;
108 } 120 }
109 121
110 PageLoadMetricsObserver::ObservePolicy 122 PageLoadMetricsObserver::ObservePolicy
111 PageLoadMetricsObserver::ShouldObserveMimeType( 123 PageLoadMetricsObserver::ShouldObserveMimeType(
112 const std::string& mime_type) const { 124 const std::string& mime_type) const {
113 return mime_type == "text/html" || mime_type == "application/xhtml+xml" 125 return mime_type == "text/html" || mime_type == "application/xhtml+xml"
114 ? CONTINUE_OBSERVING 126 ? CONTINUE_OBSERVING
115 : STOP_OBSERVING; 127 : STOP_OBSERVING;
116 } 128 }
117 129
118 } // namespace page_load_metrics 130 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698