OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSERVE R_H_ | |
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSERVE R_H_ | |
7 | |
8 #include <unordered_map> | |
9 #include <unordered_set> | |
Charlie Harrison
2017/04/10 18:39:42
not used
jkarlin
2017/04/11 16:46:28
Done.
| |
10 | |
11 #include "base/macros.h" | |
12 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" | |
13 #include "net/http/http_response_info.h" | |
14 | |
15 class AdsPageLoadMetricsObserver | |
16 : public page_load_metrics::PageLoadMetricsObserver { | |
17 public: | |
18 AdsPageLoadMetricsObserver(); | |
19 ~AdsPageLoadMetricsObserver() override; | |
20 | |
21 // page_load_metrics::PageLoadMetricsObserver implementation: | |
Charlie Harrison
2017/04/10 18:39:41
just "// page_load_metrics::PageLoadMetricsObserve
jkarlin
2017/04/11 16:46:28
Done.
| |
22 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override; | |
23 ObservePolicy OnCommitSubFrame( | |
24 content::NavigationHandle* navigation_handle) override; | |
25 ObservePolicy FlushMetricsOnAppEnterBackground( | |
26 const page_load_metrics::PageLoadTiming& timing, | |
27 const page_load_metrics::PageLoadExtraInfo& extra_info) override; | |
28 void OnLoadedResource( | |
29 const page_load_metrics::ExtraRequestInfo& extra_request_info) override; | |
30 void OnComplete(const page_load_metrics::PageLoadTiming& timing, | |
31 const page_load_metrics::PageLoadExtraInfo& info) override; | |
32 | |
33 private: | |
34 struct AdFrameData { | |
35 size_t frame_bytes; | |
36 size_t frame_bytes_uncached; | |
37 }; | |
38 | |
39 using FrameTreeNodeId = int; | |
40 const FrameTreeNodeId kInvalidFrameTreeNodeId = -1; | |
41 | |
42 friend class AdsPageLoadMetricsObserverTest; | |
43 | |
44 void RecordHistograms(); | |
45 int FindAdAncestor(content::NavigationHandle* navigation_handle); | |
46 void ProcessDelayedResources(FrameTreeNodeId frame_tree_node_id); | |
Charlie Harrison
2017/04/10 18:39:41
Please document this method.
jkarlin
2017/04/11 16:46:28
Done.
| |
47 | |
48 std::unordered_map<FrameTreeNodeId, AdFrameData> ad_frames_; | |
Charlie Harrison
2017/04/10 18:39:42
Haven't looked deeply but do you really need three
jkarlin
2017/04/11 16:46:28
A bit. ad_ancestors_ is now merged into ad_frames_
| |
49 std::unordered_map<FrameTreeNodeId, FrameTreeNodeId> ad_ancestors_; | |
Charlie Harrison
2017/04/10 18:39:41
Can you document what the keys and values are?
jkarlin
2017/04/11 16:46:28
Done.
| |
50 std::unordered_map<FrameTreeNodeId, page_load_metrics::ExtraRequestInfo> | |
Charlie Harrison
2017/04/10 18:39:42
Can you document what a "delayed" resource is?
jkarlin
2017/04/11 16:46:28
Done.
| |
51 delayed_resources_; | |
52 size_t page_bytes_ = 0; | |
53 size_t uncached_page_bytes_ = 0; | |
54 | |
55 DISALLOW_COPY_AND_ASSIGN(AdsPageLoadMetricsObserver); | |
56 }; | |
57 | |
58 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSE RVER_H_ | |
OLD | NEW |