Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: test/mjsunit/regress/regress-6209.js

Issue 2798933003: [regexp] Properly handle HeapNumbers in AdvanceStringIndex (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-regexp-gen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-6209.js
diff --git a/test/mjsunit/regress/regress-6209.js b/test/mjsunit/regress/regress-6209.js
new file mode 100644
index 0000000000000000000000000000000000000000..fa0f8880fa9a832825a354f857467e558dab5f8b
--- /dev/null
+++ b/test/mjsunit/regress/regress-6209.js
@@ -0,0 +1,25 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function testAdvanceStringIndex(lastIndex, expectedLastIndex) {
+ let exec_count = 0;
+ let last_last_index = -1;
+
+ let fake_re = {
+ exec: () => { return (exec_count++ == 0) ? [""] : null },
+ get lastIndex() { return lastIndex; },
+ set lastIndex(value) { last_last_index = value },
+ get global() { return true; },
+ get flags() { return "g"; }
+ };
+
+ assertEquals([""], RegExp.prototype[Symbol.match].call(fake_re, "abc"));
+ assertEquals(expectedLastIndex, last_last_index);
+}
+
+testAdvanceStringIndex(new Number(42), 43); // Value wrapper.
+testAdvanceStringIndex(%AllocateHeapNumber(), 1); // HeapNumber.
+testAdvanceStringIndex(4294967295, 4294967296); // HeapNumber.
« no previous file with comments | « src/builtins/builtins-regexp-gen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698