[regexp] Properly handle HeapNumbers in AdvanceStringIndex

test/mjsunit/regress/regress-6209.js

Index: test/mjsunit/regress/regress-6209.js
diff --git a/test/mjsunit/regress/regress-6209.js b/test/mjsunit/regress/regress-6209.js
new file mode 100644
index 0000000000000000000000000000000000000000..d32b9302c01ac8776dab17b3bd328cb384a2df36
--- /dev/null
+++ b/test/mjsunit/regress/regress-6209.js
@@ -0,0 +1,26 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function testAdvanceStringIndex(lastIndex, expectedLastIndex) {
+  let exec_count = 0;
+  let last_last_index = -1;
+
+  let fake_re = {
+    exec: () => { return (exec_count++ == 0) ? [""] : null },
+    [Symbol.match]: RegExp.prototype[Symbol.match],
+    get lastIndex() { return lastIndex; },
+    set lastIndex(value) { last_last_index = value },
+    get global() { return true; },
+    get flags() { return "g"; }
+  };
+
+  assertEquals([""], fake_re[Symbol.match]("abc"));

[Camillo Bruni, 2017/04/06 15:10:58]

I wonder whether ClusterFuzz would pick up the following expression quicker:

RegExp.prototype[Symbol.match].call(fake_re, "abc")

Maybe you can add that as a second assertEquals

[jgruber, 2017/04/06 16:28:34]

I replaced the old version with this. No real reason for the method to be stored
on fake_re.

+  assertEquals(expectedLastIndex, last_last_index);
+}
+
+testAdvanceStringIndex(new Number(42), 43);  // Value wrapper.
+testAdvanceStringIndex(%AllocateHeapNumber(), 1);  // HeapNumber.
+testAdvanceStringIndex(4294967295, 4294967296);  // HeapNumber.