Network traffic annotation added to update_client.

components/update_client/url_fetcher_downloader.cc

Index: components/update_client/url_fetcher_downloader.cc
diff --git a/components/update_client/url_fetcher_downloader.cc b/components/update_client/url_fetcher_downloader.cc
index 4dcd36e65e4c3e0c3e6801fb56e6e18440246cc9..c712e5edf9d1140a21326387c7730e7b55a603d4 100644
--- a/components/update_client/url_fetcher_downloader.cc
+++ b/components/update_client/url_fetcher_downloader.cc
@@ -15,6 +15,7 @@
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/update_client/utils.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "url/gurl.h"
 
@@ -36,7 +37,29 @@ UrlFetcherDownloader::~UrlFetcherDownloader() {
 void UrlFetcherDownloader::DoStartDownload(const GURL& url) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
-  url_fetcher_ = net::URLFetcher::Create(0, url, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("url_fetcher_downloader", R"(
+        semantics {
+          sender: "Component Updater"
+          description:
+            "The component updater in Chrome is responsible for updating code "
+            "and data modules such as Flash, CrlSet, Origin Trials, etc. These "
+            "modules are updated on cycles independent of the Chrome release "
+            "tracks. It runs in the browser process and communicates with a "
+            "set of servers using the Omaha protocol to find the latest "
+            "versions of components, download them, and register them with the "
+            "rest of Chrome."
+          trigger: "Manual or automatic software updates."
+          data: "A CRX representing the specific update payload."

[msramek, 2017/05/04 10:33:14]

Update payload is what is downloaded though, no? This should be about what is
uploaded with the request. So I would expect the module name, version, etc.?

[Sorin Jianu, 2017/05/08 16:21:41]

That is corrrect, the update payload is downloaded.
The request is a GET request for (usually) an obfuscated URL that refers to a
CRX.

[Ramin Halavati, 2017/05/09 05:32:26]

Does 'usually' means it's sometimes something else?

[Sorin Jianu, 2017/05/17 16:24:27]

There is no requirement for the the url to be difficult to guess. If it is
created by an automated system, the url is obfuscated. But engineers can
override this by publishing a non-obfuscated url.

[Ramin Halavati, 2017/05/18 05:11:04]

Done.

+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting: "This feature cannot be disabled."
+          policy_exception_justification: "Not implemented."
+        })");
+  url_fetcher_ = net::URLFetcher::Create(0, url, net::URLFetcher::GET, this,
+                                         traffic_annotation);
   url_fetcher_->SetRequestContext(context_getter_);
   url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                              net::LOAD_DO_NOT_SAVE_COOKIES |