Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2550)

Unified Diff: components/update_client/url_fetcher_downloader.cc

Issue 2798873002: Network traffic annotation added to update_client. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/update_client/utils.cc » ('j') | components/update_client/utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/url_fetcher_downloader.cc
diff --git a/components/update_client/url_fetcher_downloader.cc b/components/update_client/url_fetcher_downloader.cc
index 4dcd36e65e4c3e0c3e6801fb56e6e18440246cc9..58d20e393d5bb57929a1d819f9e154016d6f76e6 100644
--- a/components/update_client/url_fetcher_downloader.cc
+++ b/components/update_client/url_fetcher_downloader.cc
@@ -15,6 +15,7 @@
#include "components/data_use_measurement/core/data_use_user_data.h"
#include "components/update_client/utils.h"
#include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "url/gurl.h"
@@ -36,7 +37,28 @@ UrlFetcherDownloader::~UrlFetcherDownloader() {
void UrlFetcherDownloader::DoStartDownload(const GURL& url) {
DCHECK(thread_checker_.CalledOnValidThread());
- url_fetcher_ = net::URLFetcher::Create(0, url, net::URLFetcher::GET, this);
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("...", R"(
+ semantics {
+ sender: "..."
Sorin Jianu 2017/04/19 21:40:39 Component Updater
Ramin Halavati 2017/04/20 07:36:13 Done.
+ description: "..."
Sorin Jianu 2017/04/19 21:40:39 The component updater in Chrome is responsible for
Ramin Halavati 2017/04/20 07:36:13 Done.
+ trigger: "..."
Sorin Jianu 2017/04/19 21:40:39 Manual or automatic software updates.
Ramin Halavati 2017/04/20 07:36:13 Done.
+ data: "..."
Sorin Jianu 2017/04/19 21:40:39 A CRX representing the specific update payload.
Ramin Halavati 2017/04/20 07:36:13 Done.
+ destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
Sorin Jianu 2017/04/19 21:40:39 GOOGLE_OWNED_SERVICE
Ramin Halavati 2017/04/20 07:36:13 Done.
+ }
+ policy {
+ cookies_allowed: false
+ setting: "..."
Sorin Jianu 2017/04/19 21:40:39 This feature can't be disabled.
Ramin Halavati 2017/04/20 07:36:13 Done.
+ chrome_policy {
+ [POLICY_NAME] {
Sorin Jianu 2017/04/19 21:40:39 There is no policy associated with this feature.
Ramin Halavati 2017/04/20 07:36:13 Done.
+ policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+ [POLICY_NAME]: ... //(value to disable it)
+ }
+ }
+ policy_exception_justification: "..."
+ })");
+ url_fetcher_ = net::URLFetcher::Create(0, url, net::URLFetcher::GET, this,
+ traffic_annotation);
url_fetcher_->SetRequestContext(context_getter_);
url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SAVE_COOKIES |
« no previous file with comments | « no previous file | components/update_client/utils.cc » ('j') | components/update_client/utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698