Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: ios/shared/chrome/browser/ui/browser_list/browser_list.mm

Issue 2798863004: [ios] Extend BrowserList API. (Closed)
Patch Set: Revert name change of GetBrowserAtIndex(). Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/shared/chrome/browser/ui/browser_list/browser_list.mm
diff --git a/ios/shared/chrome/browser/ui/browser_list/browser_list.mm b/ios/shared/chrome/browser/ui/browser_list/browser_list.mm
index bb49ea6cefc25bb6b112aadc510ab2808ed3539e..10d966608d5a0f46ee4ad261f15421fe42f2ad37 100644
--- a/ios/shared/chrome/browser/ui/browser_list/browser_list.mm
+++ b/ios/shared/chrome/browser/ui/browser_list/browser_list.mm
@@ -39,13 +39,8 @@ BrowserList* BrowserList::FromBrowserState(
return static_cast<BrowserList*>(data);
}
-int BrowserList::GetBrowserCount() const {
- DCHECK_LE(browsers_.size(), static_cast<size_t>(INT_MAX));
- return static_cast<int>(browsers_.size());
-}
-
int BrowserList::ContainsIndex(int index) const {
- return 0 <= index && index < GetBrowserCount();
+ return 0 <= index && index < count();
}
Browser* BrowserList::GetBrowserAtIndex(int index) const {
@@ -53,6 +48,14 @@ Browser* BrowserList::GetBrowserAtIndex(int index) const {
return browsers_[index].get();
}
+int BrowserList::GetIndexOfBrowser(const Browser* browser) const {
+ for (int index = 0; index < count(); ++index) {
+ if (browsers_[index].get() == browser)
+ return index;
+ }
+ return kInvalidIndex;
+}
+
Browser* BrowserList::CreateNewBrowser() {
browsers_.push_back(base::MakeUnique<Browser>(browser_state_));
return browsers_.back().get();
@@ -62,3 +65,5 @@ void BrowserList::CloseBrowserAtIndex(int index) {
DCHECK(ContainsIndex(index));
browsers_.erase(browsers_.begin() + index);
}
+
+const int BrowserList::kInvalidIndex;

Powered by Google App Engine
This is Rietveld 408576698