Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: ios/chrome/browser/web/http_auth_egtest.mm

Issue 2798773002: Create ChromeEarlGrey waitForWebViewContainingText. (Closed)
Patch Set: review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/web/http_auth_egtest.mm
diff --git a/ios/chrome/browser/web/http_auth_egtest.mm b/ios/chrome/browser/web/http_auth_egtest.mm
index 21eb1224245c6659e8c5a2323d110c0a5e5b5e8d..2ac4ce20ca9d0c01389433a750da60a75e5d0b00 100644
--- a/ios/chrome/browser/web/http_auth_egtest.mm
+++ b/ios/chrome/browser/web/http_auth_egtest.mm
@@ -10,6 +10,7 @@
#include "ios/chrome/browser/ui/ui_util.h"
#include "ios/chrome/grit/ios_strings.h"
#include "ios/chrome/test/app/navigation_test_util.h"
+#import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
#import "ios/chrome/test/earl_grey/chrome_matchers.h"
#import "ios/chrome/test/earl_grey/chrome_test_case.h"
#import "ios/testing/wait_util.h"
@@ -25,7 +26,6 @@
using testing::WaitUntilConditionOrTimeout;
using testing::kWaitForPageLoadTimeout;
-using chrome_test_util::WebViewContainingText;
namespace {
@@ -96,8 +96,7 @@ void WaitForHttpAuthDialog() {
[[EarlGrey selectElementWithMatcher:LoginButton()] performAction:grey_tap()];
const std::string pageText = web::HttpAuthResponseProvider::page_text();
- [[EarlGrey selectElementWithMatcher:WebViewContainingText(pageText)]
- assertWithMatcher:grey_notNil()];
+ [ChromeEarlGrey waitForWebViewContainingText:pageText];
}
// Tests Basic HTTP Authentication with incorrect username and password.
« no previous file with comments | « ios/chrome/browser/web/child_window_open_by_dom_egtest.mm ('k') | ios/chrome/browser/web/navigation_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698