Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: ios/chrome/browser/ui/external_url_error_page_egtest.mm

Issue 2798773002: Create ChromeEarlGrey waitForWebViewContainingText. (Closed)
Patch Set: review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/external_url_error_page_egtest.mm
diff --git a/ios/chrome/browser/ui/external_url_error_page_egtest.mm b/ios/chrome/browser/ui/external_url_error_page_egtest.mm
index 176620d0969748942c9f427588a0cd1ee88e7722..6397978c3cc411e05aae9cc0d807ea45dacd7d7a 100644
--- a/ios/chrome/browser/ui/external_url_error_page_egtest.mm
+++ b/ios/chrome/browser/ui/external_url_error_page_egtest.mm
@@ -24,7 +24,6 @@
using chrome_test_util::OmniboxText;
using chrome_test_util::TapWebViewElementWithId;
-using chrome_test_util::WebViewContainingText;
using chrome_test_util::WebViewNotContainingText;
using web::test::HttpServer;
@@ -139,8 +138,7 @@ using web::test::HttpServer;
[ChromeEarlGrey loadURL:URL];
// Check that the timer has completed.
- [[EarlGrey selectElementWithMatcher:WebViewContainingText(kTimerCompleted)]
- assertWithMatcher:grey_notNil()];
+ [ChromeEarlGrey waitForWebViewContainingText:kTimerCompleted];
// DNS error page should still not appear.
[self checkErrorPageIsNotVisible];
}
@@ -176,8 +174,7 @@ using web::test::HttpServer;
[ChromeEarlGrey loadURL:URL];
TapWebViewElementWithId(kButtonId);
// Check that the timer has completed.
- [[EarlGrey selectElementWithMatcher:WebViewContainingText(kTimerCompleted)]
- assertWithMatcher:grey_notNil()];
+ [ChromeEarlGrey waitForWebViewContainingText:kTimerCompleted];
// DNS error page should still not appear.
[self checkErrorPageIsNotVisible];
}
« no previous file with comments | « ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm ('k') | ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698