Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: ios/web/shell/test/redirect_egtest.mm

Issue 2798773002: Create ChromeEarlGrey waitForWebViewContainingText. (Closed)
Patch Set: more cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/shell/test/redirect_egtest.mm
diff --git a/ios/web/shell/test/redirect_egtest.mm b/ios/web/shell/test/redirect_egtest.mm
index daa926150b9b9b4dd0f427c968e8330f4015820d..e694c867af47c2c1cb10e2639435294041b27be1 100644
--- a/ios/web/shell/test/redirect_egtest.mm
+++ b/ios/web/shell/test/redirect_egtest.mm
@@ -19,7 +19,6 @@
using web::AddressFieldText;
using web::test::HttpServer;
-using web::WebViewContainingText;
// Redirect test cases for the web shell.
@interface RedirectTestCase : WebShellTestCase
@@ -53,8 +52,7 @@ using web::WebViewContainingText;
[ShellEarlGrey loadURL:firstRedirectURL];
[[EarlGrey selectElementWithMatcher:AddressFieldText(destinationURL.spec())]
assertWithMatcher:grey_notNil()];
- [[EarlGrey selectElementWithMatcher:WebViewContainingText(kFinalPageContent)]
- assertWithMatcher:grey_notNil()];
+ [ShellEarlGrey waitForWebViewContainingText:kFinalPageContent];
}
// Tests simple 301 redirection.
@@ -77,8 +75,7 @@ using web::WebViewContainingText;
[ShellEarlGrey loadURL:firstRedirectURL];
[[EarlGrey selectElementWithMatcher:AddressFieldText(destinationURL.spec())]
assertWithMatcher:grey_notNil()];
- [[EarlGrey selectElementWithMatcher:WebViewContainingText(kFinalPageContent)]
- assertWithMatcher:grey_notNil()];
+ [ShellEarlGrey waitForWebViewContainingText:kFinalPageContent];
}
// Tests simple 302 redirection.
@@ -101,8 +98,7 @@ using web::WebViewContainingText;
[ShellEarlGrey loadURL:firstRedirectURL];
[[EarlGrey selectElementWithMatcher:AddressFieldText(destinationURL.spec())]
assertWithMatcher:grey_notNil()];
- [[EarlGrey selectElementWithMatcher:WebViewContainingText(kFinalPageContent)]
- assertWithMatcher:grey_notNil()];
+ [ShellEarlGrey waitForWebViewContainingText:kFinalPageContent];
}
@end

Powered by Google App Engine
This is Rietveld 408576698