ios/web/shell/test/context_menu_egtest.mm - Issue 2798773002: Create ChromeEarlGrey waitForWebViewContainingText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/shell/test/context_menu_egtest.mm

Issue 2798773002: Create ChromeEarlGrey waitForWebViewContainingText. (Closed)

Patch Set: better formatting Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/web/public/test/web_view_content_test_util.h ('K') | « ios/web/public/test/web_view_content_test_util.mm ('k') | ios/web/shell/test/earl_grey/shell_earl_grey.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/shell/test/context_menu_egtest.mm

diff --git a/ios/web/shell/test/context_menu_egtest.mm b/ios/web/shell/test/context_menu_egtest.mm

index 06c84caa1a3bd6ccd47975a086c3b25f3eaa4751..6cad3df670f4bfaecbb53fb176aada139ed49fdc 100644

--- a/ios/web/shell/test/context_menu_egtest.mm

+++ b/ios/web/shell/test/context_menu_egtest.mm

@@ -24,9 +24,9 @@

#error "This file requires ARC support."

#endif

+using base::SysUTF8ToNSString;

using testing::ContextMenuItemWithText;

using testing::ElementToDismissContextMenu;

-using web::WebViewContainingText;

// Context menu test cases for the web shell.

@interface ContextMenuTestCase : WebShellTestCase

@@ -52,8 +52,7 @@ using web::WebViewContainingText;

web::test::SetUpSimpleHttpServer(responses);

[ShellEarlGrey loadURL:initialURL];

- [[EarlGrey selectElementWithMatcher:WebViewContainingText(linkText)]

- assertWithMatcher:grey_notNil()];

+ [ShellEarlGrey waitForWebViewContainingText:SysUTF8ToNSString(linkText)];

[[EarlGrey selectElementWithMatcher:web::WebView()]

performAction:web::LongPressElementForContextMenu(

@@ -92,8 +91,7 @@ using web::WebViewContainingText;

web::test::SetUpSimpleHttpServer(responses);

[ShellEarlGrey loadURL:initialURL];

- [[EarlGrey selectElementWithMatcher:WebViewContainingText(linkText)]

- assertWithMatcher:grey_notNil()];

+ [ShellEarlGrey waitForWebViewContainingText:SysUTF8ToNSString(linkText)];

[[EarlGrey selectElementWithMatcher:web::WebView()]

performAction:web::LongPressElementForContextMenu(

@@ -126,8 +124,7 @@ using web::WebViewContainingText;

web::test::SetUpSimpleHttpServer(responses);

[ShellEarlGrey loadURL:initialURL];

- [[EarlGrey selectElementWithMatcher:WebViewContainingText(linkText)]

- assertWithMatcher:grey_notNil()];

+ [ShellEarlGrey waitForWebViewContainingText:SysUTF8ToNSString(linkText)];

[[EarlGrey selectElementWithMatcher:web::WebView()]

performAction:web::LongPressElementForContextMenu(

@@ -161,8 +158,7 @@ using web::WebViewContainingText;

web::test::SetUpSimpleHttpServer(responses);

[ShellEarlGrey loadURL:initialURL];

- [[EarlGrey selectElementWithMatcher:WebViewContainingText(linkText)]

- assertWithMatcher:grey_notNil()];

+ [ShellEarlGrey waitForWebViewContainingText:SysUTF8ToNSString(linkText)];

[[EarlGrey selectElementWithMatcher:web::WebView()]

performAction:web::LongPressElementForContextMenu(