services/resource_coordinator/public/interfaces/events.mojom - Issue 2798713002: Global Resource Coordinator: Basic service internals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/resource_coordinator/public/interfaces/events.mojom

Issue 2798713002: Global Resource Coordinator: Basic service internals (Closed)

Patch Set: Review fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module resource_coordinator.mojom;

	6

	7 enum EventType {

	8 TEST_EVENT,
	nasko 2017/04/21 00:17:33 nit: Another plug for k-prefixed enum values. nit: Another plug for k-prefixed enum values. oystein (OOO til 10th of July) 2017/04/21 17:57:55 Done. Show quoted text On 2017/04/21 at 00:17:33, nasko wrote: > nit: Another plug for k-prefixed enum values. Done.
	9 ON_NAVIGATION_COMMIT,

	10 ON_WEBCONTENTS_SHOWN,
	nasko 2017/04/21 00:17:33 nit: I personally find WEBCONTENTS hard to read an nit: I personally find WEBCONTENTS hard to read and WEB_CONTENTS a bit easier. oystein (OOO til 10th of July) 2017/04/21 17:57:55 Done. Show quoted text On 2017/04/21 at 00:17:33, nasko wrote: > nit: I personally find WEBCONTENTS hard to read and WEB_CONTENTS a bit easier. Done.
	11 ON_WEBCONTENTS_HIDDEN,

	12 ON_RENDERER_FRAME_CREATED,

	13 ON_PROCESS_AUDIO_STARTED,

	14 ON_PROCESS_AUDIO_STOPPED,

	15 };

	16

	17 struct Event {

	18 EventType type;

	19 };

OLD	NEW