services/resource_coordinator/public/interfaces/events.mojom - Issue 2798713002: Global Resource Coordinator: Basic service internals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/resource_coordinator/public/interfaces/events.mojom

Issue 2798713002: Global Resource Coordinator: Basic service internals (Closed)

Patch Set: Wrap EventType directly in resource_coordinator namespace when using helper Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/resource_coordinator/public/interfaces/coordination_unit.mojom ('K') | « services/resource_coordinator/public/interfaces/coordination_unit_provider.mojom ('k') | services/resource_coordinator/public/interfaces/service_constants.mojom » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module resource_coordinator.mojom;

	6

	7 enum EventType {

	8 INVALID_EVENT,
	dcheng 2017/04/18 05:40:47 This doesn't seem to be used. This doesn't seem to be used. oystein (OOO til 10th of July) 2017/04/18 20:55:34 Removed. Show quoted text On 2017/04/18 at 05:40:47, dcheng (OOO through May 2) wrote: > This doesn't seem to be used. Removed.
	9 TEST_EVENT,
	dcheng 2017/04/18 05:40:47 Add some comments to the enumerator values here. I Add some comments to the enumerator values here. It's not necessarily clear what "ON_COMMIT" is. oystein (OOO til 10th of July) 2017/04/18 20:55:34 Expanded the name a bit; I'm expecting the actual Show quoted text On 2017/04/18 at 05:40:47, dcheng (OOO through May 2) wrote: > Add some comments to the enumerator values here. It's not necessarily clear what "ON_COMMIT" is. Expanded the name a bit; I'm expecting the actual enums to go through some iterations when the service starts being used for more real usecases.
	10 ON_COMMIT,

	11 ON_WEBCONTENTS_SHOWN,

	12 ON_WEBCONTENTS_HIDDEN,

	13 ON_RENDERER_FRAME_CREATED,

	14 ON_PROCESS_AUDIO_STARTED,

	15 ON_PROCESS_AUDIO_STOPPED,

	16 };

	17

	18 struct Event {

	19 EventType type;
	dcheng 2017/04/18 05:40:47 Indent is funny Indent is funny oystein (OOO til 10th of July) 2017/04/18 20:55:33 Ah, tab rather than spaces somehow. Fixed. Show quoted text On 2017/04/18 at 05:40:47, dcheng (OOO through May 2) wrote: > Indent is funny Ah, tab rather than spaces somehow. Fixed.
	20 };

OLD	NEW