Global Resource Coordinator: Basic service internals

services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h"
+
+#include "base/logging.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_impl.h"
+#include "services/service_manager/public/cpp/service_context_ref.h"
+
+namespace resource_coordinator {
+
+CoordinationUnitProviderImpl::CoordinationUnitProviderImpl(
+    service_manager::ServiceContextRefFactory* service_ref_factory)
+    : service_ref_factory_(service_ref_factory) {
+  if (service_ref_factory)

[dcheng, 2017/04/18 05:40:46]

I'm assuming this is one of those null for testing things... is there any way to
just fake this out in the unit test to make the non-test code easier to
understand?

[oystein (OOO til 10th of July), 2017/04/18 20:55:33]

Done.

+    service_ref_ = service_ref_factory->CreateRef();
+}
+
+CoordinationUnitProviderImpl::~CoordinationUnitProviderImpl() = default;
+
+void CoordinationUnitProviderImpl::CreateCoordinationUnit(
+    mojom::CoordinationUnitRequest request,
+    const CoordinationUnitID& id) {
+  // TODO(oysteine): A strong binding here means the first binding set up
+  // to a CoordinationUnit via CoordinationUnitProvider, i.e. the authoritative
+  // one in terms of setting the context, has to outlive all of the other
+  // connections (as the rest are just duplicated and held within
+  // CoordinationUnit). Make sure this assumption is correct, or refactor into
+  // some kind of refcounted thing.
+
+  std::unique_ptr<service_manager::ServiceContextRef> service_ref;

[dcheng, 2017/04/18 05:40:46]

#include <memory> (and <utility>) here and elsewhere.

[oystein (OOO til 10th of July), 2017/04/18 20:55:33]

Done.

+  if (service_ref_factory_)
+    service_ref = service_ref_factory_->CreateRef();
+
+  // Once there's a need for custom code for various types of CUs (tabs,
+  // processes, etc) then this could become a factory function and instantiate
+  // different subclasses of CoordinationUnitImpl based on the id.type.
+  mojo::MakeStrongBinding(
+      base::MakeUnique<CoordinationUnitImpl>(id, std::move(service_ref)),
+      std::move(request));
+};
+
+// static
+void CoordinationUnitProviderImpl::Create(
+    service_manager::ServiceContextRefFactory* service_ref_factory,
+    resource_coordinator::mojom::CoordinationUnitProviderRequest request) {
+  mojo::MakeStrongBinding(
+      base::MakeUnique<CoordinationUnitProviderImpl>(service_ref_factory),
+      std::move(request));
+}
+
+}  // namespace resource_coordinator