services/resource_coordinator/public/cpp/coordination_unit_events.h - Issue 2798713002: Global Resource Coordinator: Basic service internals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/resource_coordinator/public/cpp/coordination_unit_events.h

Issue 2798713002: Global Resource Coordinator: Basic service internals (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h ('K') | « services/resource_coordinator/public/cpp/coordination_unit.typemap ('k') | services/resource_coordinator/public/cpp/coordination_unit_id.h » ('j') | services/resource_coordinator/public/cpp/coordination_unit_id.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EVENTS_H_
	Primiano Tucci (use gerrit) 2017/04/06 18:09:46 nit: macro doesn't match the file name nit: macro doesn't match the file name oystein (OOO til 10th of July) 2017/04/10 20:03:00 Done. Show quoted text On 2017/04/06 at 18:09:46, Primiano Tucci wrote: > nit: macro doesn't match the file name Done.
	5 #define SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EVENTS_H_

	6

	7 namespace resource_coordinator {

	8

	9 enum EventType : uint32_t {
	Primiano Tucci (use gerrit) 2017/04/06 18:09:46 shouldn't this be an enum class to reduce namespac shouldn't this be an enum class to reduce namespace pollution? These enum names will end up in the general resource_coordinator namespace, which means that you won't be able to use "NUM_EVENTS" or "TEST_EVENT" anywhere else (in any other enum) if this is just an enum. oystein (OOO til 10th of July) 2017/04/10 20:03:00 Oops, meant to do this. Fixed. Show quoted text On 2017/04/06 at 18:09:46, Primiano Tucci wrote: > shouldn't this be an enum class to reduce namespace pollution? > These enum names will end up in the general resource_coordinator namespace, which means that you won't be able to use "NUM_EVENTS" or "TEST_EVENT" anywhere else (in any other enum) if this is just an enum. Oops, meant to do this. Fixed.
	10 INVALID_EVENT,

	11 TEST_EVENT,

	12 ON_COMMIT,

	13 ON_WEBCONTENTS_SHOWN,

	14 ON_WEBCONTENTS_HIDDEN,

	15 ON_RENDERER_FRAME_CREATED,

	16 ON_PROCESS_AUDIO_STARTED,

	17 ON_PROCESS_AUDIO_STOPPED,

	18 NUM_EVENTS

	19 };

	20

	21 } // resource_coordinator

	22

	23 #endif // SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EVENTS_H_

OLD	NEW