Fix generic function types in variable declarations (issue 29237)

Fix generic function types in variable declarations (issue 29237)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c2f599473b738bfd0d3b04ff484b0704dae0bc77

[Brian Wilkerson, 2017-04-04 23:52:58]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-04-05 00:11:57]

LGTM

https://codereview.chromium.org/2798663003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2798663003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:8484: typeArguments[i] =
_getType(arguments[i]) ?? dynamicType;
Is this recursion?
It seems that _getType() does not return null.

https://codereview.chromium.org/2798663003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:8488: new
List<DartType>.filled(parameterCount, dynamicType);
Could be a bit simpler with typeArguments ??= ...filled() after if statements.

[Brian Wilkerson, 2017-04-05 13:23:23]

https://codereview.chromium.org/2798663003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2798663003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:8484: typeArguments[i] =
_getType(arguments[i]) ?? dynamicType;
> Is this recursion?

Yes, but it's guaranteed to terminate because it's based on the lexical
structure, not the element model.

> It seems that _getType() does not return null.

Done. This was copied from another location, which I have also fixed.

https://codereview.chromium.org/2798663003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:8488: new
List<DartType>.filled(parameterCount, dynamicType);
Done

[Brian Wilkerson, 2017-04-05 13:24:26]

Description was changed from

==========
Fix generic function types in variable declarations (issue 29237)
==========

to

==========
Fix generic function types in variable declarations (issue 29237)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c2f599473b738bfd0d3b04ff484b0704dae0bc77
==========

[Brian Wilkerson, 2017-04-05 13:24:29]

Committed patchset #1 (id:1) manually as
c2f599473b738bfd0d3b04ff484b0704dae0bc77 (presubmit successful).