src/runtime.cc - Issue 279863002: Harden %WeakCollectionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 279863002: Harden %WeakCollectionSet. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index d2dc1eb439e8f6bab147eee702000a078773a82c..308d7769a01be73e67014de9a48791dd482ae906 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1784,6 +1784,7 @@ RUNTIME_FUNCTION(Runtime_WeakCollectionSet) {

CONVERT_ARG_HANDLE_CHECKED(JSWeakCollection, weak_collection, 0);

CONVERT_ARG_HANDLE_CHECKED(Object, key, 1);

CONVERT_ARG_HANDLE_CHECKED(Object, value, 2);

+ RUNTIME_ASSERT(key->IsJSReceiver() || key->IsSymbol());

Michael Starzinger 2014/05/12 08:23:14 This applies to all four flavors of operations on

Handle<ObjectHashTable> table(

ObjectHashTable::cast(weak_collection->table()));

RUNTIME_ASSERT(table->IsKey(*key));

« no previous file with comments | « no previous file | no next file » | no next file with comments »