Issue 279863002: Harden %WeakCollectionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279863002: Harden %WeakCollectionSet. (Closed)

Created:
6 years, 7 months ago by Jarin

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Harden %WeakCollectionSet. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21265

Patch Set 2 : Added checks for WeakCollection(Has|Get|Delete) #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/runtime.cc	View	1	4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with comment. https://codereview.chromium.org/279863002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/279863002/diff/1/src/runtime.cc#newcode1787 src/runtime.cc:1787: RUNTIME_ASSERT(key->IsJSReceiver() || key->IsSymbol()); This applies to ...

6 years, 7 months ago (2014-05-12 08:23:14 UTC) #2

Jarin

6 years, 7 months ago (2014-05-12 12:05:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21265 (presubmit successful).

Expand Messages | Collapse Messages

Issue 279863002: Harden %WeakCollectionSet. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added checks for WeakCollection(Has|Get|Delete) #

Messages