Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6078)

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h

Issue 2798583002: WebUI: prevent WebContent to hold invalid pointer. (Closed)
Patch Set: prevent ConstrainedWebDialogBase to hold an invalid pointer. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h
diff --git a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h
index 606d59d866e6dcdd6d12d9b4c8853732533ce482..cca2e8daef9abb2fa810efeeb3dd817356067f59 100644
--- a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h
+++ b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
+#include "content/public/browser/web_contents_observer.h"
#include "ui/web_dialogs/web_dialog_ui.h"
#include "ui/web_dialogs/web_dialog_web_contents_delegate.h"
@@ -23,6 +24,7 @@ class WebDialogDelegate;
// Platform-agnostic base implementation of ConstrainedWebDialogDelegate.
class ConstrainedWebDialogDelegateBase
: public ConstrainedWebDialogDelegate,
+ public content::WebContentsObserver,
public ui::WebDialogWebContentsDelegate {
public:
// |browser_context| and |delegate| must outlive |this| instance, whereas
@@ -45,6 +47,9 @@ class ConstrainedWebDialogDelegateBase
gfx::Size GetMaximumSize() const override;
gfx::Size GetPreferredSize() const override;
+ // WebContentsObserver interface
+ void WebContentsDestroyed() override;
+
// WebDialogWebContentsDelegate interface.
void HandleKeyboardEvent(
content::WebContents* source,

Powered by Google App Engine
This is Rietveld 408576698