Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2451)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 2798583002: WebUI: prevent WebContent to hold invalid pointer. (Closed)
Patch Set: Fix compilation on mac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h ('K') | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
index 8eb35ccfdec34411ebcd73dbc4637358120c0e1d..0378569127f9ee59bb08f438fd9eee3c2483cb7f 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -655,8 +655,11 @@ void PrintPreviewUI::OnHidePreviewDialog() {
ConstrainedWebDialogDelegate* delegate = GetConstrainedDelegate();
if (!delegate)
return;
- delegate->ReleaseWebContentsOnDialogClose();
- background_printing_manager->OwnPrintPreviewDialog(preview_dialog);
+ std::unique_ptr<content::WebContents> preview_contents =
+ delegate->ReleaseWebContents();
+ DCHECK_EQ(preview_dialog, preview_contents.get());
+ background_printing_manager->OwnPrintPreviewDialog(
+ preview_contents.release());
OnClosePrintPreviewDialog();
}
« chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h ('K') | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698