Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7747)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Issue 2798583002: WebUI: prevent WebContent to hold invalid pointer. (Closed)
Patch Set: Fix compilation on mac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm ('k') | chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h » ('j') | chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
diff --git a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
index 57fefa85d47a93229320c9ecb890f33807bad225..2a81de25a633df5a03ca22084d3a9e3da603d6ef 100644
--- a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
+++ b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
@@ -175,8 +175,8 @@ class ConstrainedWebDialogDelegateViewViews
void OnDialogCloseFromWebUI() override {
return impl_->OnDialogCloseFromWebUI();
}
- void ReleaseWebContentsOnDialogClose() override {
- return impl_->ReleaseWebContentsOnDialogClose();
+ std::unique_ptr<content::WebContents> ReleaseWebContents() override {
+ return impl_->ReleaseWebContents();
}
gfx::NativeWindow GetNativeDialog() override {
return impl_->GetNativeDialog();
« no previous file with comments | « chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm ('k') | chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h » ('j') | chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698