Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h

Issue 2798563003: [scheduler] Add TaskQueue::Observer (Closed)
Patch Set: add todo for test timings & wake_up -> wake-up in comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
index d20b37bd54ba0b22f56f955db572b1149c128f60..28661cb0bb84e82e6a896155d30bf6b6d025768f 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
@@ -46,7 +46,7 @@ class BLINK_PLATFORM_EXPORT BudgetPoolController {
// Deletes the budget pool.
virtual void UnregisterBudgetPool(BudgetPool* budget_pool) = 0;
- // Insert a fence to prevent tasks from running and schedule a wakeup at
+ // Insert a fence to prevent tasks from running and schedule a wake_up at
// an appropriate time.
virtual void BlockQueue(base::TimeTicks now, TaskQueue* queue) = 0;
@@ -80,7 +80,7 @@ class BLINK_PLATFORM_EXPORT BudgetPoolController {
// See IncreaseThrottleRefCount & DecreaseThrottleRefCount.
//
// This class is main-thread only.
-class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TimeDomain::Observer,
+class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TaskQueue::Observer,
public BudgetPoolController {
public:
// TODO(altimin): Do not pass tracing category as const char*,
@@ -90,9 +90,9 @@ class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TimeDomain::Observer,
~TaskQueueThrottler() override;
- // TimeDomain::Observer implementation:
- void OnTimeDomainHasImmediateWork(TaskQueue*) override;
- void OnTimeDomainHasDelayedWork(TaskQueue*) override;
+ // TaskQueue::Observer implementation:
+ void OnQueueNextWakeUpChanged(TaskQueue* queue,
+ base::TimeTicks wake_up) override;
// BudgetPoolController implementation:
void AddQueueToBudgetPool(TaskQueue* queue, BudgetPool* budget_pool) override;
@@ -172,7 +172,8 @@ class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TimeDomain::Observer,
TaskQueue* queue);
TaskQueueMap queue_details_;
- base::Callback<void(TaskQueue*)> forward_immediate_work_callback_;
+ base::Callback<void(TaskQueue*, base::TimeTicks)>
+ forward_immediate_work_callback_;
scoped_refptr<TaskQueue> task_runner_;
RendererSchedulerImpl* renderer_scheduler_; // NOT OWNED
base::TickClock* tick_clock_; // NOT OWNED

Powered by Google App Engine
This is Rietveld 408576698