third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc - Issue 2798563003: [scheduler] Add TaskQueue::Observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

Issue 2798563003: [scheduler] Add TaskQueue::Observer (Closed)

Patch Set: add todo for test timings & wake_up -> wake-up in comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc ('K') | « third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h » ('j') | third_party/WebKit/public/platform/scheduler/base/task_queue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

index dc50950bdb37f0948cca5aad0dee731fd4632784..0ea77985976321263b3d6cf7489410a0e190eb1c 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

@@ -149,7 +149,7 @@ TEST_F(WebThreadImplForWorkerSchedulerTest, TestIdleTask) {

.WillByDefault(Invoke([&completion](double) { completion.Signal(); }));

thread_->postIdleTask(BLINK_FROM_HERE, task.release());

- // We need to post a wakeup task or idle work will never happen.

+ // We need to post a wake-up task or idle work will never happen.

thread_->getWebTaskRunner()->postDelayedTask(BLINK_FROM_HERE,

WTF::bind([] {}), 50ll);