Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2798563003: [scheduler] Add TaskQueue::Observer (Closed)
Patch Set: add todo for test timings & wake_up -> wake-up in comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index d771e0e1ec8e04c94b8970a6d580ec6fdc593205..0f44ea9a4bedf276bbe8001179e39240bf0f0379 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1330,16 +1330,18 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, MAYBE_VirtualTimeTest) {
params->SetString("policy", "pause");
SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
+ // TODO(scheduler-dev): Revisit timing when we have strict ordering
Sami 2017/04/05 13:16:51 Can we now also enable this for Android?
altimin 2017/04/05 13:55:18 Let's ask Alex when he's back.
Sami 2017/04/05 14:38:15 I'm pretty sure we can -- this was the bug I was f
altimin 2017/04/05 15:10:22 I'll try it in a separate CL.
Sami 2017/04/05 15:16:55 Let's do it here since this is actually the patch
altimin 2017/04/05 15:23:33 Done.
+ // guarantees.
params.reset(new base::DictionaryValue());
params->SetString("expression",
"setTimeout(function(){console.log('before')}, 1000);"
- "setTimeout(function(){console.log('after')}, 1001);");
+ "setTimeout(function(){console.log('after')}, 1002);");
SendCommand("Runtime.evaluate", std::move(params), true);
// Let virtual time advance for one second.
params.reset(new base::DictionaryValue());
params->SetString("policy", "advance");
- params->SetInteger("budget", 1000);
+ params->SetInteger("budget", 1001);
SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
WaitForNotification("Emulation.virtualTimeBudgetExpired");

Powered by Google App Engine
This is Rietveld 408576698