Issue 279853002: Re-enable key silk case benchmarks on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279853002: Re-enable key silk case benchmarks on Android (Closed)

Created:
6 years, 7 months ago by Sami

Modified:
6 years, 7 months ago

Reviewers:
tonyg, ernstm

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-enable key silk case benchmarks on Android All the known issues with these telemetry benchmarks have been fixed. BUG=355952 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270830

Patch Set 1 #

Patch Set 2 : More testing #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased against lkgr. #

Patch Set 5 : Rebased. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	tools/perf/benchmarks/rasterize_and_record_micro.py	View	4	5 chunks	+5 lines, -5 lines	0 comments	Download
	M	tools/perf/benchmarks/smoothness.py	View	4	4 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sami

These seem to be working locally for me now. Shall we see what the bots ...

6 years, 7 months ago (2014-05-15 19:23:15 UTC) #1

ernstm

On 2014/05/15 19:23:15, Sami wrote: > These seem to be working locally for me now. ...

6 years, 7 months ago (2014-05-15 20:02:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/279853002/80001

6 years, 7 months ago (2014-05-15 20:03:41 UTC) #4

tonyg

6 years, 7 months ago (2014-05-16 09:27:15 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/292453005/ by tonyg@chromium.org.

The reason for reverting is: Still failing on N5. e.g. 

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/bu...

BUG=355952.

Expand Messages | Collapse Messages