third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2798513002: Revert of Make GeometryMapper fully static

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2798513002: Revert of Make GeometryMapper fully static (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp ('k') | third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index e494270eb087c9fbba1e550f032fe40ce3a3d759..534f3cf45841e1422a5283f85b1a926d690ff6ad 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -78,12 +78,13 @@

#define CHECK_VISUAL_RECT(expected, sourceObject, ancestorObject, slopFactor) \

do { \

if ((sourceObject)->hasLayer() && (ancestorObject)->hasLayer()) { \

+ auto geometryMapper = GeometryMapper::create(); \

LayoutRect source((sourceObject)->localVisualRect()); \

source.moveBy((sourceObject)->paintOffset()); \

const auto& contentsProperties = \

*(ancestorObject)->contentsProperties(); \

FloatRect actualFloatRect(source); \

- GeometryMapper::sourceToDestinationVisualRect( \

+ geometryMapper->sourceToDestinationVisualRect( \

*(sourceObject)->localBorderBoxProperties(), contentsProperties, \

actualFloatRect); \

LayoutRect actual(actualFloatRect); \