OLD | NEW |
---|---|
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "extensions/browser/extensions_test.h" | 5 #include "extensions/browser/extensions_test.h" |
6 | 6 |
7 #include "components/keyed_service/content/browser_context_dependency_manager.h" | 7 #include "components/keyed_service/content/browser_context_dependency_manager.h" |
8 #include "components/pref_registry/pref_registry_syncable.h" | |
9 #include "components/prefs/pref_service_factory.h" | |
10 #include "components/prefs/testing_pref_store.h" | |
8 #include "content/public/browser/content_browser_client.h" | 11 #include "content/public/browser/content_browser_client.h" |
9 #include "content/public/common/content_client.h" | 12 #include "content/public/common/content_client.h" |
10 #include "content/public/test/test_browser_context.h" | 13 #include "content/public/test/test_browser_context.h" |
14 #include "extensions/browser/extension_pref_value_map.h" | |
15 #include "extensions/browser/extension_prefs.h" | |
16 #include "extensions/browser/extension_prefs_factory.h" | |
11 #include "extensions/browser/test_extensions_browser_client.h" | 17 #include "extensions/browser/test_extensions_browser_client.h" |
12 #include "extensions/test/test_content_browser_client.h" | 18 #include "extensions/test/test_content_browser_client.h" |
13 #include "extensions/test/test_content_utility_client.h" | 19 #include "extensions/test/test_content_utility_client.h" |
14 | 20 |
21 namespace { | |
22 | |
23 std::unique_ptr<content::TestBrowserContext> CreateTestIncognitoContext() { | |
24 std::unique_ptr<content::TestBrowserContext> incognito_context( | |
Devlin
2017/04/05 18:48:19
prefer base::MakeUnique<>
karandeepb
2017/04/05 20:25:48
Done.
| |
25 new content::TestBrowserContext); | |
26 incognito_context->SetOffTheRecord(true); | |
27 return incognito_context; | |
28 } | |
29 | |
30 } // namespace | |
31 | |
15 namespace extensions { | 32 namespace extensions { |
16 | 33 |
17 // This class does work in the constructor instead of SetUp() to give subclasses | 34 // This class does work in the constructor instead of SetUp() to give subclasses |
18 // a valid BrowserContext to use while initializing their members. For example: | 35 // a valid BrowserContext to use while initializing their members. For example: |
19 // | 36 // |
20 // class MyExtensionsTest : public ExtensionsTest { | 37 // class MyExtensionsTest : public ExtensionsTest { |
21 // MyExtensionsTest() | 38 // MyExtensionsTest() |
22 // : my_object_(browser_context())) { | 39 // : my_object_(browser_context())) { |
23 // } | 40 // } |
24 // }; | 41 // }; |
42 // TODO(crbug.com/708256): All these instances are setup in the constructor, but | |
43 // destroyed in TearDown(), which may cause problems. Move this initialization | |
44 // to SetUp(). | |
25 ExtensionsTest::ExtensionsTest() | 45 ExtensionsTest::ExtensionsTest() |
26 : content_browser_client_(new TestContentBrowserClient), | 46 : content_browser_client_(new TestContentBrowserClient), |
27 content_utility_client_(new TestContentUtilityClient), | 47 content_utility_client_(new TestContentUtilityClient), |
28 browser_context_(new content::TestBrowserContext), | 48 browser_context_(new content::TestBrowserContext), |
49 incognito_context_(CreateTestIncognitoContext()), | |
29 extensions_browser_client_( | 50 extensions_browser_client_( |
30 new TestExtensionsBrowserClient(browser_context_.get())) { | 51 new TestExtensionsBrowserClient(browser_context_.get())) { |
31 content::SetBrowserClientForTesting(content_browser_client_.get()); | 52 content::SetBrowserClientForTesting(content_browser_client_.get()); |
32 content::SetUtilityClientForTesting(content_utility_client_.get()); | 53 content::SetUtilityClientForTesting(content_utility_client_.get()); |
33 ExtensionsBrowserClient::Set(extensions_browser_client_.get()); | 54 ExtensionsBrowserClient::Set(extensions_browser_client_.get()); |
34 extensions_browser_client_->set_extension_system_factory( | 55 extensions_browser_client_->set_extension_system_factory( |
35 &extension_system_factory_); | 56 &extension_system_factory_); |
57 extensions_browser_client_->SetIncognitoContext(incognito_context_.get()); | |
58 | |
59 // Set up all the dependencies of ExtensionPrefs. | |
60 extension_pref_value_map_.reset(new ExtensionPrefValueMap()); | |
61 PrefServiceFactory factory; | |
62 factory.set_user_prefs(new TestingPrefStore()); | |
63 factory.set_extension_prefs(new TestingPrefStore()); | |
64 user_prefs::PrefRegistrySyncable* pref_registry = | |
65 new user_prefs::PrefRegistrySyncable(); | |
66 // Prefs should be registered before the PrefService is created. | |
67 ExtensionPrefs::RegisterProfilePrefs(pref_registry); | |
68 pref_service_ = factory.Create(pref_registry); | |
69 | |
70 std::unique_ptr<ExtensionPrefs> extension_prefs(ExtensionPrefs::Create( | |
71 browser_context(), pref_service_.get(), | |
72 browser_context()->GetPath().AppendASCII("Extensions"), | |
73 extension_pref_value_map_.get(), false /* extensions_disabled */, | |
74 std::vector<ExtensionPrefsObserver*>())); | |
75 | |
76 ExtensionPrefsFactory::GetInstance()->SetInstanceForTesting( | |
77 browser_context(), std::move(extension_prefs)); | |
36 } | 78 } |
37 | 79 |
38 ExtensionsTest::~ExtensionsTest() { | 80 ExtensionsTest::~ExtensionsTest() { |
39 ExtensionsBrowserClient::Set(nullptr); | 81 ExtensionsBrowserClient::Set(nullptr); |
40 content::SetBrowserClientForTesting(nullptr); | 82 content::SetBrowserClientForTesting(nullptr); |
41 content::SetUtilityClientForTesting(nullptr); | 83 content::SetUtilityClientForTesting(nullptr); |
42 } | 84 } |
43 | 85 |
44 void ExtensionsTest::SetUp() { | 86 void ExtensionsTest::SetUp() { |
45 // Crashing here? Don't use this class in Chrome's unit_tests. See header. | 87 // Crashing here? Don't use this class in Chrome's unit_tests. See header. |
46 BrowserContextDependencyManager::GetInstance() | 88 BrowserContextDependencyManager::GetInstance() |
47 ->CreateBrowserContextServicesForTest(browser_context_.get()); | 89 ->CreateBrowserContextServicesForTest(browser_context_.get()); |
48 } | 90 } |
49 | 91 |
50 void ExtensionsTest::TearDown() { | 92 void ExtensionsTest::TearDown() { |
51 // Allows individual tests to have BrowserContextKeyedServiceFactory objects | 93 // Allows individual tests to have BrowserContextKeyedServiceFactory objects |
52 // as member variables instead of singletons. The individual services will be | 94 // as member variables instead of singletons. The individual services will be |
53 // cleaned up before the factories are destroyed. | 95 // cleaned up before the factories are destroyed. |
54 BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices( | 96 BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices( |
55 browser_context_.get()); | 97 browser_context_.get()); |
98 | |
99 // TODO(crbug.com/708256): |extension_browser_client_| is reset here but not | |
100 // unset as the singleton until the destructor. This can lead to use after | |
101 // free errors. | |
56 extensions_browser_client_.reset(); | 102 extensions_browser_client_.reset(); |
57 browser_context_.reset(); | 103 browser_context_.reset(); |
104 incognito_context_.reset(); | |
105 pref_service_.reset(); | |
58 } | 106 } |
59 | 107 |
60 } // namespace extensions | 108 } // namespace extensions |
OLD | NEW |