Extensions: Pull duplicated functionality into ExtensionsTest fixture.

extensions/browser/event_router_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/event_router.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/histogram_tester.h"
 #include "base/values.h"
-#include "components/pref_registry/pref_registry_syncable.h"
-#include "components/prefs/pref_service_factory.h"
-#include "components/prefs/testing_pref_store.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/test/mock_render_process_host.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/event_listener_map.h"
-#include "extensions/browser/extension_pref_value_map.h"
-#include "extensions/browser/extension_prefs.h"
-#include "extensions/browser/extension_prefs_factory.h"
 #include "extensions/browser/extensions_test.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::DictionaryValue;
 using base::ListValue;
 using base::Value;
 
 namespace extensions {
@@ skipping 150 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(EventRouterTest);
 };
 
 class EventRouterFilterTest : public ExtensionsTest {
  public:
   EventRouterFilterTest() {}
 
   void SetUp() override {
     ExtensionsTest::SetUp();
-
     render_process_host_.reset(
         new content::MockRenderProcessHost(browser_context()));
-
-    // Set up all the dependencies of ExtensionPrefs.
-    extension_pref_value_map_.reset(new ExtensionPrefValueMap());
-    PrefServiceFactory factory;
-    factory.set_user_prefs(new TestingPrefStore());
-    factory.set_extension_prefs(new TestingPrefStore());
-    user_prefs::PrefRegistrySyncable* pref_registry =
-        new user_prefs::PrefRegistrySyncable();
-    // Prefs should be registered before the PrefService is created.
-    ExtensionPrefs::RegisterProfilePrefs(pref_registry);
-    pref_service_ = factory.Create(pref_registry);
-
-    std::unique_ptr<ExtensionPrefs> extension_prefs(ExtensionPrefs::Create(
-        browser_context(), pref_service_.get(),
-        browser_context()->GetPath().AppendASCII("Extensions"),
-        extension_pref_value_map_.get(), false /* extensions_disabled */,
-        std::vector<ExtensionPrefsObserver*>()));
-
-    ExtensionPrefsFactory::GetInstance()->SetInstanceForTesting(
-        browser_context(), std::move(extension_prefs));
-
     ASSERT_TRUE(EventRouter::Get(browser_context()));  // constructs EventRouter
   }
 
   void TearDown() override {
     render_process_host_.reset();
     ExtensionsTest::TearDown();
   }
 
   content::RenderProcessHost* render_process_host() const {
     return render_process_host_.get();
@@ skipping 34 matching lines @@
     DictionaryValue::Iterator iter(*filtered_events);
     if (iter.key() != event_name)
       return nullptr;
 
     const base::ListValue* filter_list = nullptr;
     iter.value().GetAsList(&filter_list);
     return filter_list;
   }
 
   std::unique_ptr<content::RenderProcessHost> render_process_host_;
-  std::unique_ptr<ExtensionPrefValueMap> extension_pref_value_map_;
-  std::unique_ptr<PrefService> pref_service_;
 
   DISALLOW_COPY_AND_ASSIGN(EventRouterFilterTest);
 };
 
 TEST_F(EventRouterTest, GetBaseEventName) {
   // Normal event names are passed through unchanged.
   EXPECT_EQ("foo.onBar", EventRouter::GetBaseEventName("foo.onBar"));
 
   // Sub-events are converted to the part before the slash.
   EXPECT_EQ("foo.onBar", EventRouter::GetBaseEventName("foo.onBar/123"));
@@ skipping 153 matching lines @@
 
   // Remove the third filter.
   event_router()->RemoveFilteredEventListener(kEventName, render_process_host(),
                                               kExtensionId, *filters[2], true);
   ASSERT_FALSE(ContainsFilter(kExtensionId, kEventName, *filters[0]));
   ASSERT_FALSE(ContainsFilter(kExtensionId, kEventName, *filters[1]));
   ASSERT_FALSE(ContainsFilter(kExtensionId, kEventName, *filters[2]));
 }
 
 }  // namespace extensions