Extensions: Pull duplicated functionality into ExtensionsTest fixture.

extensions/browser/app_window/app_window_geometry_cache_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window_geometry_cache.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
-#include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/mock_pref_change_callback.h"
-#include "components/prefs/pref_service_factory.h"
-#include "components/prefs/testing_pref_store.h"
 #include "content/public/test/test_browser_context.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_utils.h"
-#include "extensions/browser/extension_pref_value_map.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extensions_test.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/value_builder.h"
-#include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 namespace extensions {
 
 namespace {
 const char kWindowId[] = "windowid";
 const char kWindowId2[] = "windowid2";
 
 // Create a very simple extension with id.
@@ skipping 30 matching lines @@
   void LoadExtension(const std::string& extension_id);
   void UnloadExtension(const std::string& extension_id);
 
   // Creates and adds an extension with associated prefs. Returns the extension
   // ID.
   std::string AddExtensionWithPrefs(const std::string& name);
 
  protected:
   base::MessageLoopForUI ui_message_loop_;
   content::TestBrowserThread ui_thread_;
-  std::unique_ptr<ExtensionPrefValueMap> extension_pref_value_map_;
-  std::unique_ptr<PrefService> pref_service_;
-  std::unique_ptr<ExtensionPrefs> extension_prefs_;
+  ExtensionPrefs* extension_prefs_;  // Weak.
   std::unique_ptr<AppWindowGeometryCache> cache_;
 };
 
 void AppWindowGeometryCacheTest::SetUp() {
   ExtensionsTest::SetUp();
-
-  // Set up all the dependencies of ExtensionPrefs.
-  extension_pref_value_map_.reset(new ExtensionPrefValueMap);
-  PrefServiceFactory factory;
-  factory.set_user_prefs(new TestingPrefStore);
-  factory.set_extension_prefs(new TestingPrefStore);
-  user_prefs::PrefRegistrySyncable* pref_registry =
-      new user_prefs::PrefRegistrySyncable;
-  // Prefs should be registered before the PrefService is created.
-  ExtensionPrefs::RegisterProfilePrefs(pref_registry);
-  pref_service_ = factory.Create(pref_registry);
-
-  extension_prefs_.reset(ExtensionPrefs::Create(
-      browser_context(), pref_service_.get(),
-      browser_context()->GetPath().AppendASCII("Extensions"),
-      extension_pref_value_map_.get(), false /* extensions_disabled */,
-      std::vector<ExtensionPrefsObserver*>()));
-
-  cache_.reset(
-      new AppWindowGeometryCache(browser_context(), extension_prefs_.get()));
+  extension_prefs_ = ExtensionPrefs::Get(browser_context());
+  cache_.reset(new AppWindowGeometryCache(browser_context(), extension_prefs_));
   cache_->SetSyncDelayForTests(0);
 }
 
 void AppWindowGeometryCacheTest::TearDown() {
   cache_.reset();
-  extension_prefs_.reset();
-  pref_service_.reset();
-  extension_pref_value_map_.reset();
-
   ExtensionsTest::TearDown();
 }
 
 void AppWindowGeometryCacheTest::AddGeometryAndLoadExtension(
     const std::string& extension_id,
     const std::string& window_id,
     const gfx::Rect& bounds,
     const gfx::Rect& screen_bounds,
     ui::WindowShowState state) {
   std::unique_ptr<base::DictionaryValue> dict =
@@ skipping 230 matching lines @@
 
   const std::string extension_id = AddExtensionWithPrefs("ext1");
   gfx::Rect bounds1(100, 200, 300, 400);
   gfx::Rect bounds2(200, 400, 600, 800);
   gfx::Rect bounds2_duplicate(200, 400, 600, 800);
 
   gfx::Rect screen_bounds1(0, 0, 1600, 900);
   gfx::Rect screen_bounds2(0, 0, 1366, 768);
   gfx::Rect screen_bounds2_duplicate(0, 0, 1366, 768);
 
-  MockPrefChangeCallback observer(pref_service_.get());
+  MockPrefChangeCallback observer(pref_service());
   PrefChangeRegistrar registrar;
-  registrar.Init(pref_service_.get());
+  registrar.Init(pref_service());
   registrar.Add("extensions.settings", observer.GetCallback());
 
   // Write the first bounds - it should do > 0 writes.
   EXPECT_CALL(observer, OnPreferenceChanged(_));
   cache_->SaveGeometry(
       extension_id, kWindowId, bounds1, screen_bounds1, ui::SHOW_STATE_NORMAL);
   WaitForSync();
   Mock::VerifyAndClearExpectations(&observer);
 
   // Write a different bounds - it should also do > 0 writes.
@@ skipping 49 matching lines @@
   // The first added window should no longer have cached geometry.
   EXPECT_FALSE(cache_->GetGeometry(extension_id, "window_0", NULL, NULL, NULL));
   // All other windows should still exist.
   for (size_t i = 1; i < AppWindowGeometryCache::kMaxCachedWindows + 1; ++i) {
     std::string window_id = "window_" + base::SizeTToString(i);
     EXPECT_TRUE(cache_->GetGeometry(extension_id, window_id, NULL, NULL, NULL));
   }
 }
 
 }  // namespace extensions