Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/url_formatter/elide_url_unittest.cc

Issue 2798443003: Run all TextEliderTest tests on iOS (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/url_formatter/elide_url_unittest.cc
diff --git a/components/url_formatter/elide_url_unittest.cc b/components/url_formatter/elide_url_unittest.cc
index e92df4eabc475325f914f5797263086c57a9ebb2..f8f52f964166b8b4cac8886697e0ec24a2f17dda 100644
--- a/components/url_formatter/elide_url_unittest.cc
+++ b/components/url_formatter/elide_url_unittest.cc
@@ -183,11 +183,6 @@ TEST(TextEliderTest, TestHostEliding) {
"reallyreallyreallylongdomainname.com"},
{"http://foo", "foo"},
{"http://foo.bar", "foo.bar"},
-#if !defined(OS_IOS)
- // iOS width calculations are off by a letter from other platforms for
- // strings with too many kerned letters on the default font set.
- // TODO(rohitrao): Fix secure_display::ElideHost for iOS
- // (crbug.com/517604).
{"http://subdomain.google.com", kEllipsisStr + ".google.com"},
{"http://a.b.c.d.e.f.com", kEllipsisStr + "f.com"},
{"http://subdomain.foo.bar", kEllipsisStr + "in.foo.bar"},
@@ -197,7 +192,6 @@ TEST(TextEliderTest, TestHostEliding) {
// IDN - Greek alpha.beta.gamma.delta.epsilon.zeta.com
{"http://xn--mxa.xn--nxa.xn--oxa.xn--pxa.xn--qxa.xn--rxa.com",
kEllipsisStr + ".\xCE\xB5.\xCE\xB6.com"},
-#endif // !defined(OS_IOS)
};
for (size_t i = 0; i < arraysize(testcases); ++i) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698