Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2798423003: Redo "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes." (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Redo "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes." R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/6feb58bfb1e98476c09f45be706a49559b3d8fa8

Patch Set 1 #

Patch Set 2 : remove unused field, reuse computed uses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -64 lines) Patch
M pkg/compiler/lib/src/ssa/nodes.dart View 1 3 chunks +129 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 4 chunks +31 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sra1
3 years, 8 months ago (2017-04-06 20:48:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6feb58bfb1e98476c09f45be706a49559b3d8fa8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698