Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: remoting/client/client_status_logger_unittest.cc

Issue 2798393007: Use SignalingAddress in SignalStrategy insterface. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/client_status_logger_unittest.cc
diff --git a/remoting/client/client_status_logger_unittest.cc b/remoting/client/client_status_logger_unittest.cc
index e308bf9acc2ff07274e4f7a1f815536d43d9392d..9d4263d0db5037ebc15369745de552ac92bcf9ae 100644
--- a/remoting/client/client_status_logger_unittest.cc
+++ b/remoting/client/client_status_logger_unittest.cc
@@ -9,6 +9,7 @@
#include "remoting/protocol/performance_tracker.h"
#include "remoting/signaling/mock_signal_strategy.h"
#include "remoting/signaling/server_log_entry_unittest.h"
+#include "remoting/signaling/signaling_address.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libjingle_xmpp/xmllite/xmlelement.h"
@@ -64,7 +65,7 @@ MATCHER(IsStatisticsLog, "") {
class ClientStatusLoggerTest : public testing::Test {
public:
- ClientStatusLoggerTest() {}
+ ClientStatusLoggerTest() : signal_strategy_(SignalingAddress(kClientJid)) {}
void SetUp() override {
EXPECT_CALL(signal_strategy_, AddListener(_));
EXPECT_CALL(signal_strategy_, RemoveListener(_));
@@ -84,8 +85,6 @@ TEST_F(ClientStatusLoggerTest, LogStateChange) {
base::RunLoop run_loop;
{
InSequence s;
- EXPECT_CALL(signal_strategy_, GetLocalJid())
- .WillRepeatedly(Return(kClientJid));
EXPECT_CALL(signal_strategy_, AddListener(_));
EXPECT_CALL(signal_strategy_, GetNextId());
EXPECT_CALL(signal_strategy_, SendStanzaPtr(
@@ -110,8 +109,6 @@ TEST_F(ClientStatusLoggerTest, LogStateChangeError) {
base::RunLoop run_loop;
{
InSequence s;
- EXPECT_CALL(signal_strategy_, GetLocalJid())
- .WillRepeatedly(Return(kClientJid));
EXPECT_CALL(signal_strategy_, AddListener(_));
EXPECT_CALL(signal_strategy_, GetNextId());
EXPECT_CALL(signal_strategy_, SendStanzaPtr(
@@ -133,8 +130,6 @@ TEST_F(ClientStatusLoggerTest, LogStatistics) {
base::RunLoop run_loop;
{
InSequence s;
- EXPECT_CALL(signal_strategy_, GetLocalJid())
- .WillRepeatedly(Return(kClientJid));
EXPECT_CALL(signal_strategy_, AddListener(_));
EXPECT_CALL(signal_strategy_, GetNextId());
EXPECT_CALL(signal_strategy_, SendStanzaPtr(

Powered by Google App Engine
This is Rietveld 408576698