Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 2798393003: ABANDONED CL: Add more methods needing Get prefix. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index 4180e15a27c4d4efea9addd1660da62336e3fcb9..2e6bf6252dcabf82ec691d8810f3e9ae738d5676 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -659,13 +659,16 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
// with a "Get" prefix.
static const char* kConflictingMethods[] = {
"animationWorklet",
+ "attrNodeList",
"audioWorklet",
"binaryType",
"blob",
"channelCountMode",
"color",
"compositorElementId",
+ "constructionStack",
"counterDirectives",
+ "counterMaps"
"document",
"element",
"emptyChromeClient",
@@ -679,13 +682,16 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"frameBlameContext",
"frontend",
"gridCell",
+ "harfBuzzFontCache",
"hash",
"heapObjectHeader",
"iconURL",
"image",
+ "infoMap",
"inputMethodController",
"inputType",
"interpolationTypes",
+ "intervalArena",
"layout",
"layoutBlock",
"layoutObject",
@@ -702,11 +708,13 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"navigationType",
"node",
"notificationManager",
+ "originAccessMap",
"outcome",
"pagePopup",
"paintWorklet",
"path",
"position",
+ "presentationAttributeCache",
"processingInstruction",
"readyState",
"relList",
@@ -721,11 +729,13 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"scrollAnimator",
"selectionInDOMTree",
"selectionInFlatTree",
+ "selectionVisualRectMap",
"settings",
"signalingState",
"snapshotById",
"state",
"string",
+ "styleSharingList",
"styleSheet",
"supplementable",
"text",
@@ -739,10 +749,12 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"vector",
"visibleSelection",
"visibleSelectionInFlatTree",
+ "weakHeapObjectSet",
"webFrame",
"widget",
"wordBoundaries",
- "wrapperTypeInfo",
+ "worldMap",
+ "wrapperTypeInfo"
};
for (const auto& conflicting_method : kConflictingMethods) {
if (old_method_name == conflicting_method)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698