Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: chrome/browser/chromeos/settings/device_settings_service.cc

Issue 2798343003: Merge "cros: Fix flaky owner detection" (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_service.cc
diff --git a/chrome/browser/chromeos/settings/device_settings_service.cc b/chrome/browser/chromeos/settings/device_settings_service.cc
index d95ffbd9f3bcbf70d7f96f9476fda91283076b34..1fc8db37ad3d016f464cf4a39b5967710b598351 100644
--- a/chrome/browser/chromeos/settings/device_settings_service.cc
+++ b/chrome/browser/chromeos/settings/device_settings_service.cc
@@ -194,6 +194,9 @@ void DeviceSettingsService::InitOwner(
username_ = username;
owner_settings_service_ = owner_settings_service;
+ // Reset the flag since consumer ownership should be established now.
+ will_establish_consumer_ownership_ = false;
+
EnsureReload(true);
}
@@ -206,6 +209,10 @@ DeviceSettingsService::GetOwnerSettingsService() const {
return owner_settings_service_.get();
}
+void DeviceSettingsService::MarkWillEstablishConsumerOwnership() {
+ will_establish_consumer_ownership_ = true;
+}
+
void DeviceSettingsService::AddObserver(Observer* observer) {
observers_.AddObserver(observer);
}
@@ -221,7 +228,11 @@ void DeviceSettingsService::OwnerKeySet(bool success) {
}
public_key_ = NULL;
- EnsureReload(true);
+
+ if (GetOwnershipStatus() == OWNERSHIP_TAKEN ||
+ !will_establish_consumer_ownership_) {
+ EnsureReload(true);
+ }
}
void DeviceSettingsService::PropertyChangeComplete(bool success) {
@@ -230,7 +241,10 @@ void DeviceSettingsService::PropertyChangeComplete(bool success) {
return;
}
- EnsureReload(false);
+ if (GetOwnershipStatus() == OWNERSHIP_TAKEN ||
+ !will_establish_consumer_ownership_) {
+ EnsureReload(false);
+ }
}
void DeviceSettingsService::Enqueue(

Powered by Google App Engine
This is Rietveld 408576698