Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 279833003: Cast: Add missing enum and PacketEvent field to cast_messages. (Closed)

Created:
6 years, 7 months ago by imcheng
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, imcheng+watch_chromium.org, hclam+watch_chromium.org, fischman+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, wjia+watch_chromium.org, jshin+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Add missing enum and PacketEvent field to cast_messages. Due to the event type refactoring landed earlier, an enum field EventMediaType was added to PacketEvent. PacketEvent is transmitted via IPC from browser to renderer so we need to add them to the IPC definition as well. Also fix compile in cast_sender_app. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270262

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/cast_messages.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/renderer/media/cast_ipc_dispatcher_unittest.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
M media/cast/logging/encoding_event_subscriber.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/logging/logging_defines.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M media/cast/test/sender.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
imcheng
PTAL. This will need to be merged to M36 I think if branch point already ...
6 years, 7 months ago (2014-05-12 21:03:23 UTC) #1
Alpha Left Google
LGTM.
6 years, 7 months ago (2014-05-13 05:32:47 UTC) #2
dcheng
Sorry, I'm in Zurich for BlinkOn atm. You should find another IPC reviewer if you ...
6 years, 7 months ago (2014-05-13 05:37:26 UTC) #3
imcheng
+jschuh, could you please take a look at chrome/common/cast_messages.h? In there, I added declaration for ...
6 years, 7 months ago (2014-05-13 18:03:57 UTC) #4
jschuh
ipc security lgtm. (notes: opaque enum used for logging)
6 years, 7 months ago (2014-05-13 20:32:33 UTC) #5
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 7 months ago (2014-05-13 20:39:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/279833003/40001
6 years, 7 months ago (2014-05-13 20:41:54 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 00:14:15 UTC) #8
Message was sent while issue was closed.
Change committed as 270262

Powered by Google App Engine
This is Rietveld 408576698