Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2798263004: Test can pass if minification accidentally picks same name (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test can pass if minification accidentally picks same name Ideally, we should make all tests that use x.runtimeType.toString() use classes with longer names. BUG= Committed: https://github.com/dart-lang/sdk/commit/427ccea1b204bf1eacbb5f7aec8396dd192f6982

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language/language_dart2js.status View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 8 months ago (2017-04-07 00:33:21 UTC) #2
sra1
Committed patchset #1 (id:1) manually as 427ccea1b204bf1eacbb5f7aec8396dd192f6982 (presubmit successful).
3 years, 8 months ago (2017-04-07 00:33:44 UTC) #4
Emily Fortuna
3 years, 8 months ago (2017-04-07 01:38:37 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2798263004/diff/1/tests/language/language_dar...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/2798263004/diff/1/tests/language/language_dar...
tests/language/language_dart2js.status:198: f_bounded_quantification4_test:
Fail, Pass # Issue 12605
ugh. should we re-open that bug with what you learned and assign to dart2js?
https://github.com/dart-lang/sdk/issues/12605

Powered by Google App Engine
This is Rietveld 408576698