Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: docs/clang_tool_refactoring.md

Issue 2798233002: Share logic for generating compile DB with run_tool.py (Closed)
Patch Set: thakis comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/pylib/clang/compile_db.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/clang_tool_refactoring.md
diff --git a/docs/clang_tool_refactoring.md b/docs/clang_tool_refactoring.md
index 9b49df11b3a9c7c57b7bf1815967bb5dcd3c0113..9fc3a7f89cc1ddaf2c512946a0fee239f83897f8 100644
--- a/docs/clang_tool_refactoring.md
+++ b/docs/clang_tool_refactoring.md
@@ -125,13 +125,6 @@ $gen_targets = $(ninja -C out/gn -t targets all \
ninja -C out/Debug $gen_targets
```
-On Windows, generate the compile DB first, and after making any source changes.
-Then omit the `--generate-compdb` in later steps.
-
-```shell
-tools/clang/scripts/generate_win_compdb.py out/Debug
-```
-
Then run the actual clang tool to generate a list of edits:
```shell
« no previous file with comments | « no previous file | tools/clang/pylib/clang/compile_db.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698