Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: tools/clang/scripts/generate_win_compdb.py

Issue 2798233002: Share logic for generating compile DB with run_tool.py (Closed)
Patch Set: thakis comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/scripts/generate_compdb.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/generate_win_compdb.py
diff --git a/tools/clang/scripts/generate_win_compdb.py b/tools/clang/scripts/generate_win_compdb.py
deleted file mode 100755
index 6edd5938cb3abb9a74bd15d861d8ed1ef1de8e3d..0000000000000000000000000000000000000000
--- a/tools/clang/scripts/generate_win_compdb.py
+++ /dev/null
@@ -1,83 +0,0 @@
-#!/usr/bin/env python
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""
-Clang tools on Windows are still a bit busted. The tooling can't handle
-backslashes in paths, doesn't understand how to read .rsp files, etc. In
-addition, ninja generates compile commands prefixed with the ninja msvc helper,
-which also confuses clang. This script generates a compile DB that should mostly
-work until clang tooling can be improved upstream.
-"""
-
-import argparse
-import os
-import re
-import json
-import shlex
-import subprocess
-import sys
-
-
-_NINJA_MSVC_WRAPPER = re.compile('ninja -t msvc -e .+? -- ')
-_RSP_RE = re.compile(r' (@(.+?\.rsp)) ')
-
-
-def _ProcessEntry(e):
- # Strip off the ninja -t msvc wrapper.
- e['command'] = _NINJA_MSVC_WRAPPER.sub('', e['command'])
-
- # Prepend --driver-mode=cl to the command's arguments.
- # Escape backslashes so shlex doesn't try to interpret them.
- escaped_command = e['command'].replace('\\', '\\\\')
- split_command = shlex.split(escaped_command)
- e['command'] = ' '.join(
- split_command[:1] + ['--driver-mode=cl'] + split_command[1:])
-
- # Expand the contents of the response file, if any.
- # http://llvm.org/bugs/show_bug.cgi?id=21634
- try:
- match = _RSP_RE.search(e['command'])
- rsp_path = os.path.join(e['directory'], match.group(2))
- rsp_contents = file(rsp_path).read()
- e['command'] = ''.join([
- e['command'][:match.start(1)],
- rsp_contents,
- e['command'][match.end(1):]])
- except IOError:
- pass
-
- return e
-
-
-def main(argv):
- # Parse argument
- parser = argparse.ArgumentParser()
- parser.add_argument(
- 'build_path',
- nargs='?',
- help='Path to build directory',
- default='out/Debug')
- args = parser.parse_args()
- # First, generate the compile database.
- print 'Generating compile DB with ninja...'
- compile_db_as_json = subprocess.check_output(shlex.split(
- 'ninja -C %s -t compdb cc cxx objc objcxx' % args.build_path))
-
- compile_db = json.loads(compile_db_as_json)
- print 'Read in %d entries from the compile db' % len(compile_db)
- compile_db = [_ProcessEntry(e) for e in compile_db]
- original_length = len(compile_db)
-
- # Filter out NaCl stuff. The clang tooling chokes on them.
- compile_db = [e for e in compile_db if '_nacl.cc.pdb' not in e['command']
- and '_nacl_win64.cc.pdb' not in e['command']]
- print 'Filtered out %d entries...' % (original_length - len(compile_db))
- f = file('%s/compile_commands.json' % args.build_path, 'w')
- f.write(json.dumps(compile_db, indent=2))
- print 'Done!'
-
-
-if __name__ == '__main__':
- sys.exit(main(sys.argv[1:]))
« no previous file with comments | « tools/clang/scripts/generate_compdb.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698