Use test UUIDs for device bluetooth unit tests

device/bluetooth/bluetooth_device_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 1259 matching lines @@
   ResetEventCounts();
   device->CreateGattConnection(GetGattConnectionCallback(Call::EXPECTED),
                                GetConnectErrorCallback(Call::NOT_EXPECTED));
   TestBluetoothAdapterObserver observer(adapter_);
   SimulateGattConnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(device->IsConnected());
 
   // Discover services
   std::vector<std::string> services;
-  services.push_back("00000000-0000-1000-8000-00805f9b34fb");
-  services.push_back("00000001-0000-1000-8000-00805f9b34fb");
+  services.push_back(kTestUUIDGenericAccess);

[ortuno, 2017/04/06 00:56:19]

optional: We used push_back because initializer lists were not available then.
All new code uses initializer lists e.g. [1]. Since we are already changing the
UUIDs we might as well use initializer lists everywhere:

SimulateGattServicesDiscovered(
  device,
  std::vector<std::string>({kTestUUIDGenericAccess, kTestUUIDHeartRate}));


[1]
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_device_unitte...

[juncai, 2017/04/07 18:50:19]

Done.

+  services.push_back(kTestUUIDHeartRate);
   SimulateGattServicesDiscovered(device, services);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(device->IsGattServicesDiscoveryComplete());
   EXPECT_EQ(2u, device->GetGattServices().size());
   EXPECT_EQ(1, observer.gatt_services_discovered_count());
 
   // Disconnect from the device
   device->DisconnectGatt();
   SimulateGattDisconnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_FALSE(device->IsConnected());
   EXPECT_FALSE(device->IsGattServicesDiscoveryComplete());
   EXPECT_EQ(0u, device->GetGattServices().size());
 
   // Verify that the device can be connected to again
   device->CreateGattConnection(GetGattConnectionCallback(Call::EXPECTED),
                                GetConnectErrorCallback(Call::NOT_EXPECTED));
   SimulateGattConnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(device->IsConnected());
 
   // Verify that service discovery can be done again
   std::vector<std::string> services2;
-  services2.push_back("00000002-0000-1000-8000-00805f9b34fb");
+  services2.push_back(kTestUUIDGenericAttribute);
   SimulateGattServicesDiscovered(device, services2);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(device->IsGattServicesDiscoveryComplete());
   EXPECT_EQ(1u, device->GetGattServices().size());
   EXPECT_EQ(2, observer.gatt_services_discovered_count());
 }
 #endif  // defined(OS_ANDROID) || defined(OS_MACOSX)
 
 #if defined(OS_ANDROID) || defined(OS_MACOSX)
 // Calls CreateGattConnection, but simulate errors connecting. Also, verifies
@@ skipping 39 matching lines @@
   BluetoothDevice* device = SimulateLowEnergyDevice(3);
   device->CreateGattConnection(GetGattConnectionCallback(Call::EXPECTED),
                                GetConnectErrorCallback(Call::NOT_EXPECTED));
   TestBluetoothAdapterObserver observer(adapter_);
   ResetEventCounts();
   SimulateGattConnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1, gatt_discovery_attempts_);
 
   std::vector<std::string> services;
-  services.push_back("00000000-0000-1000-8000-00805f9b34fb");
-  services.push_back("00000001-0000-1000-8000-00805f9b34fb");
+  services.push_back(kTestUUIDGenericAccess);
+  services.push_back(kTestUUIDHeartRate);
   SimulateGattServicesDiscovered(device, services);
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(1, observer.gatt_services_discovered_count());
   EXPECT_EQ(2, observer.gatt_service_added_count());
 }
 #endif  // defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_MACOSX)
 
 #if defined(OS_ANDROID)
 // macOS: Not applicable: This can never happen because when
@@ skipping 13 matching lines @@
                                GetConnectErrorCallback(Call::NOT_EXPECTED));
   ResetEventCounts();
   SimulateGattConnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1, gatt_discovery_attempts_);
 
   RememberDeviceForSubsequentAction(device);
   DeleteDevice(device);
 
   std::vector<std::string> services;
-  services.push_back("00000000-0000-1000-8000-00805f9b34fb");
-  services.push_back("00000001-0000-1000-8000-00805f9b34fb");
+  services.push_back(kTestUUIDGenericAccess);
+  services.push_back(kTestUUIDHeartRate);
   SimulateGattServicesDiscovered(nullptr /* use remembered device */, services);
   base::RunLoop().RunUntilIdle();
 }
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_ANDROID)
 // macOS: Not applicable: This can never happen because when
 // the device gets destroyed the CBPeripheralDelegate is also destroyed
 // and no more events are dispatched.
 TEST_F(BluetoothTest, GattServicesDiscoveredError_AfterDeleted) {
@@ skipping 36 matching lines @@
                                GetConnectErrorCallback(Call::NOT_EXPECTED));
   ResetEventCounts();
   SimulateGattConnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1, gatt_discovery_attempts_);
 
   SimulateGattDisconnection(device);
   base::RunLoop().RunUntilIdle();
 
   std::vector<std::string> services;
-  services.push_back("00000000-0000-1000-8000-00805f9b34fb");
-  services.push_back("00000001-0000-1000-8000-00805f9b34fb");
+  services.push_back(kTestUUIDGenericAccess);
+  services.push_back(kTestUUIDHeartRate);
   SimulateGattServicesDiscovered(device, services);
   base::RunLoop().RunUntilIdle();
 
   EXPECT_FALSE(device->IsGattServicesDiscoveryComplete());
   EXPECT_EQ(0u, device->GetGattServices().size());
 }
 #endif  // defined(OS_ANDROID) || defined(OS_MACOSX)
 
 #if defined(OS_ANDROID) || defined(OS_MACOSX)
 TEST_F(BluetoothTest, GattServicesDiscoveredError_AfterDisconnection) {
@@ skipping 33 matching lines @@
   StartLowEnergyDiscoverySession();
   BluetoothDevice* device = SimulateLowEnergyDevice(3);
   device->CreateGattConnection(GetGattConnectionCallback(Call::EXPECTED),
                                GetConnectErrorCallback(Call::NOT_EXPECTED));
   ResetEventCounts();
   SimulateGattConnection(device);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1, gatt_discovery_attempts_);
 
   std::vector<std::string> services;
-  services.push_back("00000000-0000-1000-8000-00805f9b34fb");
+  services.push_back(kTestUUIDGenericAccess);
   // 2 duplicate UUIDs creating 2 instances.
-  services.push_back("00000001-0000-1000-8000-00805f9b34fb");
-  services.push_back("00000001-0000-1000-8000-00805f9b34fb");
+  services.push_back(kTestUUIDHeartRate);
+  services.push_back(kTestUUIDHeartRate);
   SimulateGattServicesDiscovered(device, services);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(3u, device->GetGattServices().size());
 
   // Test GetGattService:
   std::string service_id1 = device->GetGattServices()[0]->GetIdentifier();
   std::string service_id2 = device->GetGattServices()[1]->GetIdentifier();
   std::string service_id3 = device->GetGattServices()[2]->GetIdentifier();
   EXPECT_TRUE(device->GetGattService(service_id1));
   EXPECT_TRUE(device->GetGattService(service_id2));
@@ skipping 77 matching lines @@
                     ->GetPrimaryServicesByUUID(BluetoothUUID(
                         BluetoothTestBase::kTestUUIDGenericAttribute))
                     .empty());
 
     EXPECT_NE(services[0]->GetIdentifier(), services[1]->GetIdentifier());
   }
 }
 #endif  // defined(OS_ANDROID) || defined(OS_MACOSX) || defined(OS_WIN)
 
 }  // namespace device