Use modifiable top-level scope for Fasta parser in file_state.

Use modifiable top-level scope for Fasta parser in file_state.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b65cd81b45dce2a3d8f1ecb4abaea371ba998c9b

[Paul Berry, 2017-04-06 17:11:35]

Why is this the right thing to do?  Does it fix a bug?  If so it would be nice
for the CL to contain a test that now passes.

[scheglov, 2017-04-06 17:16:24]

On 2017/04/06 17:11:35, Paul Berry wrote:
> Why is this the right thing to do?  Does it fix a bug?  If so it would be nice
> for the CL to contain a test that now passes.

I think that implementation of Scope was changed in the last couple of weeks.
It went unnoticed because we test using Fasta parser in analyzer by enabling
temporary (and manually) FileState.USE_FASTA_PARSER to `true`.
So, when I did this yesterday, there were 1000+ errors.
And this change make it back to 222 failing tests.

My plan is to keep this option and test manually until we have almost everything
implemented, and then switch it to `true`.

[Paul Berry, 2017-04-06 17:17:25]

On 2017/04/06 17:16:24, scheglov wrote:
> On 2017/04/06 17:11:35, Paul Berry wrote:
> > Why is this the right thing to do?  Does it fix a bug?  If so it would be
nice
> > for the CL to contain a test that now passes.
> 
> I think that implementation of Scope was changed in the last couple of weeks.
> It went unnoticed because we test using Fasta parser in analyzer by enabling
> temporary (and manually) FileState.USE_FASTA_PARSER to `true`.
> So, when I did this yesterday, there were 1000+ errors.
> And this change make it back to 222 failing tests.
> 
> My plan is to keep this option and test manually until we have almost
everything
> implemented, and then switch it to `true`.

Ok, thanks for the explanation.  Lgtm.

[scheglov, 2017-04-06 17:26:34]

Description was changed from

==========
Use modifiable top-level scope for Fasta parser in file_state.

R=paulberry@google.com
BUG=
==========

to

==========
Use modifiable top-level scope for Fasta parser in file_state.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b65cd81b45dce2a3d8f1ecb4abaea371ba998c9b
==========

[scheglov, 2017-04-06 17:26:35]

Committed patchset #1 (id:1) manually as
b65cd81b45dce2a3d8f1ecb4abaea371ba998c9b (presubmit successful).