Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: ash/common/shelf/shelf_model_observer.h

Issue 2798173002: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|. (Closed)
Patch Set: Remove get|set delegate helpers; cleanup. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_model_observer.h
diff --git a/ash/common/shelf/shelf_model_observer.h b/ash/common/shelf/shelf_model_observer.h
index 194e202675ce111c1b70522a39f44110ff8528fe..9953513c9c8cbb63c821fc01e7194fb355457195 100644
--- a/ash/common/shelf/shelf_model_observer.h
+++ b/ash/common/shelf/shelf_model_observer.h
@@ -11,7 +11,6 @@
namespace ash {
struct ShelfItem;
-class ShelfItemDelegate;
class ASH_EXPORT ShelfModelObserver {
public:
@@ -26,17 +25,9 @@ class ASH_EXPORT ShelfModelObserver {
// of the arguments.
virtual void ShelfItemMoved(int start_index, int target_index) = 0;
- // Invoked when the state of an item changes. |old_item| is the item
- // before the change.
+ // Invoked after an item changes. |old_item| is the item before the change.
virtual void ShelfItemChanged(int index, const ShelfItem& old_item) = 0;
- // Gets called when a ShelfItemDelegate gets changed. Note that
- // |item_delegate| can be null.
- // NOTE: This is added a temporary fix for M39 to fix crbug.com/429870.
- // TODO(skuhne): Find the real reason for this problem and remove this fix.
James Cook 2017/04/07 20:42:22 Hooray!
msw 2017/04/07 22:02:16 Acknowledged.
- virtual void OnSetShelfItemDelegate(ShelfID id,
- ShelfItemDelegate* item_delegate) = 0;
-
protected:
virtual ~ShelfModelObserver() {}
};

Powered by Google App Engine
This is Rietveld 408576698