Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

Issue 2798173002: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|. (Closed)
Patch Set: Address comment; fix browser tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h" 5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h"
6 6
7 #include "ash/public/cpp/app_launch_id.h" 7 #include "ash/public/cpp/app_launch_id.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/profiles/profile_manager.h" 10 #include "chrome/browser/profiles/profile_manager.h"
(...skipping 25 matching lines...) Expand all
36 void ChromeLauncherControllerMus::SetItemType(ash::ShelfID id, 36 void ChromeLauncherControllerMus::SetItemType(ash::ShelfID id,
37 ash::ShelfItemType type) { 37 ash::ShelfItemType type) {
38 NOTIMPLEMENTED(); 38 NOTIMPLEMENTED();
39 } 39 }
40 40
41 void ChromeLauncherControllerMus::SetItemStatus(ash::ShelfID id, 41 void ChromeLauncherControllerMus::SetItemStatus(ash::ShelfID id,
42 ash::ShelfItemStatus status) { 42 ash::ShelfItemStatus status) {
43 NOTIMPLEMENTED(); 43 NOTIMPLEMENTED();
44 } 44 }
45 45
46 void ChromeLauncherControllerMus::SetShelfItemDelegate(
47 ash::ShelfID id,
48 std::unique_ptr<ash::ShelfItemDelegate> item_delegate) {
49 NOTIMPLEMENTED();
50 }
51
52 void ChromeLauncherControllerMus::CloseLauncherItem(ash::ShelfID id) { 46 void ChromeLauncherControllerMus::CloseLauncherItem(ash::ShelfID id) {
53 NOTIMPLEMENTED(); 47 NOTIMPLEMENTED();
54 } 48 }
55 49
56 bool ChromeLauncherControllerMus::IsPinned(ash::ShelfID id) { 50 bool ChromeLauncherControllerMus::IsPinned(ash::ShelfID id) {
57 NOTIMPLEMENTED(); 51 NOTIMPLEMENTED();
58 return false; 52 return false;
59 } 53 }
60 54
61 void ChromeLauncherControllerMus::SetV1AppStatus(const std::string& app_id, 55 void ChromeLauncherControllerMus::SetV1AppStatus(const std::string& app_id,
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 NOTIMPLEMENTED(); 162 NOTIMPLEMENTED();
169 return base::string16(); 163 return base::string16();
170 } 164 }
171 165
172 BrowserShortcutLauncherItemController* 166 BrowserShortcutLauncherItemController*
173 ChromeLauncherControllerMus::GetBrowserShortcutLauncherItemController() { 167 ChromeLauncherControllerMus::GetBrowserShortcutLauncherItemController() {
174 NOTIMPLEMENTED(); 168 NOTIMPLEMENTED();
175 return nullptr; 169 return nullptr;
176 } 170 }
177 171
178 ash::ShelfItemDelegate* ChromeLauncherControllerMus::GetShelfItemDelegate(
179 const ash::ShelfID id) {
180 NOTIMPLEMENTED();
181 return nullptr;
182 }
183
184 bool ChromeLauncherControllerMus::ShelfBoundsChangesProbablyWithUser( 172 bool ChromeLauncherControllerMus::ShelfBoundsChangesProbablyWithUser(
185 ash::WmShelf* shelf, 173 ash::WmShelf* shelf,
186 const AccountId& account_id) const { 174 const AccountId& account_id) const {
187 NOTIMPLEMENTED(); 175 NOTIMPLEMENTED();
188 return false; 176 return false;
189 } 177 }
190 178
191 void ChromeLauncherControllerMus::OnUserProfileReadyToSwitch(Profile* profile) { 179 void ChromeLauncherControllerMus::OnUserProfileReadyToSwitch(Profile* profile) {
192 NOTIMPLEMENTED(); 180 NOTIMPLEMENTED();
193 } 181 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 item->image = *image.ToSkBitmap(); 222 item->image = *image.ToSkBitmap();
235 // TOOD(msw): Actually pin the item and install its delegate; this code is 223 // TOOD(msw): Actually pin the item and install its delegate; this code is
236 // unused at the moment. See http://crbug.com/647879 224 // unused at the moment. See http://crbug.com/647879
237 AppIconLoader* app_icon_loader = GetAppIconLoaderForApp(app_id); 225 AppIconLoader* app_icon_loader = GetAppIconLoaderForApp(app_id);
238 if (app_icon_loader) { 226 if (app_icon_loader) {
239 app_icon_loader->FetchImage(app_id); 227 app_icon_loader->FetchImage(app_id);
240 app_icon_loader->UpdateImage(app_id); 228 app_icon_loader->UpdateImage(app_id);
241 } 229 }
242 } 230 }
243 } 231 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698