Fix for URL opening code

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 191 matching lines @@
 - (void)activeSpaceDidChange:(NSNotification*)inNotification;
 - (void)checkForAnyKeyWindows;
 - (BOOL)userWillWaitForInProgressDownloads:(int)downloadCount;
 - (BOOL)shouldQuitWithInProgressDownloads;
 - (void)executeApplication:(id)sender;
 - (void)profileWasRemoved:(const base::FilePath&)profilePath;
 
 // Opens a tab for each GURL in |urls|.
 - (void)openUrls:(const std::vector<GURL>&)urls;
 
+// Creates StartupBrowserCreator and opens |urls| with it.
+- (void)openUrlsViaStartupBrowserCreator:(const std::vector<GURL>&)urls
+                               inBrowser:(Browser*)browser;
+
 // This class cannot open urls until startup has finished. The urls that cannot
 // be opened are cached in |startupUrls_|. This method must be called exactly
 // once after startup has completed. It opens the urls in |startupUrls_|, and
 // clears |startupUrls_|.
 - (void)openStartupUrls;
 
 // Opens a tab for each GURL in |urls|. If there is exactly one tab open before
 // this method is called, and that tab is the NTP, then this method closes the
 // NTP after all the |urls| have been opened.
 - (void)openUrlsReplacingNTP:(const std::vector<GURL>&)urls;
@@ skipping 1049 matching lines @@
 
 // Returns true if a browser window may be opened for the last active profile.
 - (bool)canOpenNewBrowser {
   Profile* profile = [self safeLastProfileForNewWindows];
 
   const PrefService* prefs = g_browser_process->local_state();
   return !profile->IsGuestSession() ||
          prefs->GetBoolean(prefs::kBrowserGuestModeEnabled);
 }
 
+- (void)openUrlsViaStartupBrowserCreator:(const std::vector<GURL>&)urls
+                               inBrowser:(Browser*)browser {
+  base::CommandLine dummy(base::CommandLine::NO_PROGRAM);
+  chrome::startup::IsFirstRun first_run =
+      first_run::IsChromeFirstRun() ? chrome::startup::IS_FIRST_RUN
+                                    : chrome::startup::IS_NOT_FIRST_RUN;
+  StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run);
+  launch.OpenURLsInBrowser(browser, false, urls);
+}
+
 // Various methods to open URLs that we get in a native fashion. We use
 // StartupBrowserCreator here because on the other platforms, URLs to open come
 // through the ProcessSingleton, and it calls StartupBrowserCreator. It's best
 // to bottleneck the openings through that for uniform handling.
 - (void)openUrls:(const std::vector<GURL>&)urls {
   if (!startupComplete_) {
     startupUrls_.insert(startupUrls_.end(), urls.begin(), urls.end());
     return;
   }
 
-  Browser* browser = chrome::GetLastActiveBrowser();
-  // if no browser window exists then create one with no tabs to be filled in
-  if (!browser) {
-    browser = new Browser(Browser::CreateParams([self lastProfile], true));
-    browser->window()->Show();
+  Profile* profile = [self lastProfile];
+  SessionStartupPref pref = StartupBrowserCreator::GetSessionStartupPref(
+      *base::CommandLine::ForCurrentProcess(), profile);
+
+  if (pref.type == SessionStartupPref::LAST) {
+    if (SessionRestore::IsRestoring(profile)) {
+      // In case of session restore, remember |urls|, so they will be opened
+      // after session is resored, in the tabs next to it.
+      SessionRestore::AddURLsToOpen(profile, urls);
+    } else {
+      Browser* browser = chrome::GetLastActiveBrowser();
+      if (!browser) {
+        // This behavior is needed for the case when chromium app is launched,
+        // but there are no open indows.
+        browser = new Browser(Browser::CreateParams([self lastProfile], true));

[Avi (use Gerrit), 2017/06/01 19:54:31]

I just learned this, but you need to use [self safeLastProfileForNewWindows]
instead, otherwise you'll crash in Guest Mode.

[eugenebng, 2017/06/07 10:42:11]

Done. Thank you for sharing that!

+        browser->window()->Show();
+        SessionRestore::AddURLsToOpen(profile, urls);
+      } else {
+        [self openUrlsViaStartupBrowserCreator:urls inBrowser:browser];
+      }
+    }
+  } else {
+    Browser* browser = chrome::GetLastActiveBrowser();
+    // If no browser window exists then create one with no tabs to be filled in.
+    if (!browser) {
+      browser = new Browser(Browser::CreateParams([self lastProfile], true));

[Avi (use Gerrit), 2017/06/01 19:54:31]

Same here.

[eugenebng, 2017/06/07 10:42:11]

Done

+      browser->window()->Show();
+    }
+    [self openUrlsViaStartupBrowserCreator:urls inBrowser:browser];
   }
-
-  base::CommandLine dummy(base::CommandLine::NO_PROGRAM);
-  chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
-      chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
-  StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run);
-  launch.OpenURLsInBrowser(browser, false, urls);
 }
 
 - (void)getUrl:(NSAppleEventDescriptor*)event
      withReply:(NSAppleEventDescriptor*)reply {
   NSString* urlStr = [[event paramDescriptorForKeyword:keyDirectObject]
                       stringValue];
 
   GURL gurl(base::SysNSStringToUTF8(urlStr));
   std::vector<GURL> gurlVector;
   gurlVector.push_back(gurl);
@@ skipping 303 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac